Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: d987bee007
Branches Tags
electron
/
patches
/
chromium
/
chore_remove_conflicting_allow_unsafe_libc_calls.patch

chore_remove_conflicting_allow_unsafe_libc_calls.patch 2.1 KB
History Raw

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Charles Kerr <[email protected]>
    3. 

  3. Date: Sat, 22 Feb 2025 13:15:39 -0600
    4. 

  4. Subject: chore: remove conflicting allow_unsafe_libc_calls
    5. 

  5. 

  6. We want builds to fail if a buffer warning comes from Electron code but
    7. 

  7. not from code that we don't maintain (e.g. upstream Chromium code), so
    8. 

  8. //electron/electron_unsafe_buffer_paths.txt turns off Chromium warnings.
    9. 

  9. 

  10. There are some upstream files that generate warnings *and* also have
    11. 

  11. pragmas that override //electron/electron_unsafe_buffer_paths.txt,
    12. 

  12. forcing them to be tested. This breaks our build.
    13. 

  13. 

  14. Files can be removed from this patch when upstream either removes the
    15. 

  15. pragma or fixes the other warnings. This patch can be removed when no
    16. 

  16. files are left.
    17. 

  17. 

  18. diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc
    19. 

  19. index 7d5d0106a3675b3fa21b0e00a755f5c0ed11c87b..d26c645d70b54b31815c8140954ee6d0a34fa8af 100644
    20. 

  20. --- a/net/cookies/parsed_cookie.cc
    21. 

  21. +++ b/net/cookies/parsed_cookie.cc
    22. 

  22. @@ -2,11 +2,6 @@
    23. 

  23.  // Use of this source code is governed by a BSD-style license that can be
    24. 

  24.  // found in the LICENSE file.
    25. 

  25.  
    26. 

  26. -#ifdef UNSAFE_BUFFERS_BUILD
    27. 

  27. -// TODO(crbug.com/390223051): Remove C-library calls to fix the errors.
    28. 

  28. -#pragma allow_unsafe_libc_calls
    29. 

  29. -#endif
    30. 

  30. -
    31. 

  31.  // Portions of this code based on Mozilla:
    32. 

  32.  //   (netwerk/cookie/src/nsCookieService.cpp)
    33. 

  33.  /* ***** BEGIN LICENSE BLOCK *****
    34. 

  34. diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc
    35. 

  35. index 813f2f7f274bf02b6679b9321ae83948ab634697..2c61297669ba7d513f8493dfb6f478245f5c7c58 100644
    36. 

  36. --- a/net/http/http_response_headers.cc
    37. 

  37. +++ b/net/http/http_response_headers.cc
    38. 

  38. @@ -2,11 +2,6 @@
    39. 

  39.  // Use of this source code is governed by a BSD-style license that can be
    40. 

  40.  // found in the LICENSE file.
    41. 

  41.  
    42. 

  42. -#ifdef UNSAFE_BUFFERS_BUILD
    43. 

  43. -// TODO(crbug.com/390223051): Remove C-library calls to fix the errors.
    44. 

  44. -#pragma allow_unsafe_libc_calls
    45. 

  45. -#endif
    46. 

  46. -
    47. 

  47.  // The rules for header parsing were borrowed from Firefox:
    48. 

  48.  // http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/http/src/nsHttpResponseHead.cpp
    49. 

  49.  // The rules for parsing content-types were also borrowed from Firefox:
    50.