From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sat, 22 Feb 2025 13:15:39 -0600 Subject: chore: remove conflicting allow_unsafe_libc_calls We want builds to fail if a buffer warning comes from Electron code but not from code that we don't maintain (e.g. upstream Chromium code), so //electron/electron_unsafe_buffer_paths.txt turns off Chromium warnings. There are some upstream files that generate warnings *and* also have pragmas that override //electron/electron_unsafe_buffer_paths.txt, forcing them to be tested. This breaks our build. Files can be removed from this patch when upstream either removes the pragma or fixes the other warnings. This patch can be removed when no files are left. diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc index 7d5d0106a3675b3fa21b0e00a755f5c0ed11c87b..d26c645d70b54b31815c8140954ee6d0a34fa8af 100644 --- a/net/cookies/parsed_cookie.cc +++ b/net/cookies/parsed_cookie.cc @@ -2,11 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifdef UNSAFE_BUFFERS_BUILD -// TODO(crbug.com/390223051): Remove C-library calls to fix the errors. -#pragma allow_unsafe_libc_calls -#endif - // Portions of this code based on Mozilla: // (netwerk/cookie/src/nsCookieService.cpp) /* ***** BEGIN LICENSE BLOCK ***** diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc index 813f2f7f274bf02b6679b9321ae83948ab634697..2c61297669ba7d513f8493dfb6f478245f5c7c58 100644 --- a/net/http/http_response_headers.cc +++ b/net/http/http_response_headers.cc @@ -2,11 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifdef UNSAFE_BUFFERS_BUILD -// TODO(crbug.com/390223051): Remove C-library calls to fix the errors. -#pragma allow_unsafe_libc_calls -#endif - // The rules for header parsing were borrowed from Firefox: // http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/http/src/nsHttpResponseHead.cpp // The rules for parsing content-types were also borrowed from Firefox: