security-warnings-spec.ts 7.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227
  1. import { expect } from 'chai';
  2. import * as http from 'http';
  3. import * as fs from 'fs';
  4. import * as path from 'path';
  5. import * as url from 'url';
  6. import { BrowserWindow, WebPreferences } from 'electron/main';
  7. import { closeWindow } from './window-helpers';
  8. import { AddressInfo } from 'net';
  9. import { emittedUntil } from './events-helpers';
  10. const messageContainsSecurityWarning = (event: Event, level: number, message: string) => {
  11. return message.indexOf('Electron Security Warning') > -1;
  12. };
  13. const isLoaded = (event: Event, level: number, message: string) => {
  14. return (message === 'loaded');
  15. };
  16. describe('security warnings', () => {
  17. let server: http.Server;
  18. let w: BrowserWindow;
  19. let useCsp = true;
  20. let useTrustedTypes = false;
  21. let serverUrl: string;
  22. before((done) => {
  23. // Create HTTP Server
  24. server = http.createServer((request, response) => {
  25. const uri = url.parse(request.url!).pathname!;
  26. let filename = path.join(__dirname, '..', 'spec', 'fixtures', 'pages', uri);
  27. fs.stat(filename, (error, stats) => {
  28. if (error) {
  29. response.writeHead(404, { 'Content-Type': 'text/plain' });
  30. response.end();
  31. return;
  32. }
  33. if (stats.isDirectory()) {
  34. filename += '/index.html';
  35. }
  36. fs.readFile(filename, 'binary', (err, file) => {
  37. if (err) {
  38. response.writeHead(404, { 'Content-Type': 'text/plain' });
  39. response.end();
  40. return;
  41. }
  42. const cspHeaders = [
  43. ...(useCsp ? ['script-src \'self\' \'unsafe-inline\''] : []),
  44. ...(useTrustedTypes ? ['require-trusted-types-for \'script\'; trusted-types *'] : [])
  45. ];
  46. response.writeHead(200, { 'Content-Security-Policy': cspHeaders });
  47. response.write(file, 'binary');
  48. response.end();
  49. });
  50. });
  51. }).listen(0, '127.0.0.1', () => {
  52. serverUrl = `http://127.0.0.1:${(server.address() as AddressInfo).port}`;
  53. done();
  54. });
  55. });
  56. after(() => {
  57. // Close server
  58. server.close();
  59. server = null as unknown as any;
  60. });
  61. afterEach(async () => {
  62. useCsp = true;
  63. useTrustedTypes = false;
  64. await closeWindow(w);
  65. w = null as unknown as any;
  66. });
  67. it('should warn about Node.js integration with remote content', async () => {
  68. w = new BrowserWindow({
  69. show: false,
  70. webPreferences: {
  71. nodeIntegration: true,
  72. contextIsolation: false
  73. }
  74. });
  75. w.loadURL(`${serverUrl}/base-page-security.html`);
  76. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  77. expect(message).to.include('Node.js Integration with Remote Content');
  78. });
  79. it('should not warn about Node.js integration with remote content from localhost', async () => {
  80. w = new BrowserWindow({
  81. show: false,
  82. webPreferences: {
  83. nodeIntegration: true
  84. }
  85. });
  86. w.loadURL(`${serverUrl}/base-page-security-onload-message.html`);
  87. const [,, message] = await emittedUntil(w.webContents, 'console-message', isLoaded);
  88. expect(message).to.not.include('Node.js Integration with Remote Content');
  89. });
  90. const generateSpecs = (description: string, webPreferences: WebPreferences) => {
  91. describe(description, () => {
  92. it('should warn about disabled webSecurity', async () => {
  93. w = new BrowserWindow({
  94. show: false,
  95. webPreferences: {
  96. webSecurity: false,
  97. ...webPreferences
  98. }
  99. });
  100. w.loadURL(`${serverUrl}/base-page-security.html`);
  101. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  102. expect(message).to.include('Disabled webSecurity');
  103. });
  104. it('should warn about insecure Content-Security-Policy', async () => {
  105. w = new BrowserWindow({
  106. show: false,
  107. webPreferences
  108. });
  109. useCsp = false;
  110. w.loadURL(`${serverUrl}/base-page-security.html`);
  111. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  112. expect(message).to.include('Insecure Content-Security-Policy');
  113. });
  114. it('should warn about insecure Content-Security-Policy (Trusted Types)', async () => {
  115. w = new BrowserWindow({
  116. show: false,
  117. webPreferences
  118. });
  119. useCsp = false;
  120. useTrustedTypes = true;
  121. w.loadURL(`${serverUrl}/base-page-security.html`);
  122. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  123. expect(message).to.include('Insecure Content-Security-Policy');
  124. });
  125. it('should warn about allowRunningInsecureContent', async () => {
  126. w = new BrowserWindow({
  127. show: false,
  128. webPreferences: {
  129. allowRunningInsecureContent: true,
  130. ...webPreferences
  131. }
  132. });
  133. w.loadURL(`${serverUrl}/base-page-security.html`);
  134. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  135. expect(message).to.include('allowRunningInsecureContent');
  136. });
  137. it('should warn about experimentalFeatures', async () => {
  138. w = new BrowserWindow({
  139. show: false,
  140. webPreferences: {
  141. experimentalFeatures: true,
  142. ...webPreferences
  143. }
  144. });
  145. w.loadURL(`${serverUrl}/base-page-security.html`);
  146. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  147. expect(message).to.include('experimentalFeatures');
  148. });
  149. it('should warn about enableBlinkFeatures', async () => {
  150. w = new BrowserWindow({
  151. show: false,
  152. webPreferences: {
  153. enableBlinkFeatures: 'my-cool-feature',
  154. ...webPreferences
  155. }
  156. });
  157. w.loadURL(`${serverUrl}/base-page-security.html`);
  158. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  159. expect(message).to.include('enableBlinkFeatures');
  160. });
  161. it('should warn about allowpopups', async () => {
  162. w = new BrowserWindow({
  163. show: false,
  164. webPreferences
  165. });
  166. w.loadURL(`${serverUrl}/webview-allowpopups.html`);
  167. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  168. expect(message).to.include('allowpopups');
  169. });
  170. it('should warn about insecure resources', async () => {
  171. w = new BrowserWindow({
  172. show: false,
  173. webPreferences
  174. });
  175. w.loadURL(`${serverUrl}/insecure-resources.html`);
  176. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  177. expect(message).to.include('Insecure Resources');
  178. });
  179. it('should not warn about loading insecure-resources.html from localhost', async () => {
  180. w = new BrowserWindow({
  181. show: false,
  182. webPreferences
  183. });
  184. w.loadURL(`${serverUrl}/insecure-resources.html`);
  185. const [,, message] = await emittedUntil(w.webContents, 'console-message', messageContainsSecurityWarning);
  186. expect(message).to.not.include('insecure-resources.html');
  187. });
  188. });
  189. };
  190. generateSpecs('without sandbox', { contextIsolation: false });
  191. generateSpecs('with sandbox', { sandbox: true, contextIsolation: false });
  192. });