expose_setuseragent_on_networkcontext.patch 4.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Wed, 28 Aug 2019 12:21:25 -0700
  4. Subject: expose SetUserAgent on NetworkContext
  5. Applying
  6. https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
  7. it's merged. There may end up being a better way of doing this, or the
  8. patch may be merged upstream, at which point this patch should be
  9. removed.
  10. diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
  11. index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a289703d8b0577 100644
  12. --- a/net/url_request/static_http_user_agent_settings.h
  13. +++ b/net/url_request/static_http_user_agent_settings.h
  14. @@ -26,13 +26,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
  15. accept_language_ = new_accept_language;
  16. }
  17. + void set_user_agent(const std::string& new_user_agent) {
  18. + user_agent_ = new_user_agent;
  19. + }
  20. +
  21. // HttpUserAgentSettings implementation
  22. std::string GetAcceptLanguage() const override;
  23. std::string GetUserAgent() const override;
  24. private:
  25. std::string accept_language_;
  26. - const std::string user_agent_;
  27. + std::string user_agent_;
  28. DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings);
  29. };
  30. diff --git a/services/network/network_context.cc b/services/network/network_context.cc
  31. index 3dda30a8157648644e8c70d1836d43d4143029dc..08e75a10a91bfe9047e448af589438b332cd984e 100644
  32. --- a/services/network/network_context.cc
  33. +++ b/services/network/network_context.cc
  34. @@ -1140,6 +1140,13 @@ void NetworkContext::SetNetworkConditions(
  35. std::move(network_conditions));
  36. }
  37. +void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
  38. + // This may only be called on NetworkContexts created with a constructor that
  39. + // calls ApplyContextParamsToBuilder.
  40. + DCHECK(user_agent_settings_);
  41. + user_agent_settings_->set_user_agent(new_user_agent);
  42. +}
  43. +
  44. void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
  45. // This may only be called on NetworkContexts created with the constructor
  46. // that calls MakeURLRequestContext().
  47. diff --git a/services/network/network_context.h b/services/network/network_context.h
  48. index 06b1a0d550de946aa41efca2be4efde694cc24c7..fe7c5c6501838e480c2bc95823e9f562839ad99c 100644
  49. --- a/services/network/network_context.h
  50. +++ b/services/network/network_context.h
  51. @@ -254,6 +254,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
  52. void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
  53. void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
  54. mojom::NetworkConditionsPtr conditions) override;
  55. + void SetUserAgent(const std::string& new_user_agent) override;
  56. void SetAcceptLanguage(const std::string& new_accept_language) override;
  57. void SetEnableReferrers(bool enable_referrers) override;
  58. #if BUILDFLAG(IS_CHROMEOS_ASH)
  59. diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
  60. index 1304a9189c1c12024847ef973ab0ed426496e6b3..69e8d361c9e14f325fc897dad2819b2a57819e75 100644
  61. --- a/services/network/public/mojom/network_context.mojom
  62. +++ b/services/network/public/mojom/network_context.mojom
  63. @@ -952,6 +952,9 @@ interface NetworkContext {
  64. SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
  65. NetworkConditions? conditions);
  66. + // Updates the user agent to be used for requests.
  67. + SetUserAgent(string new_user_agent);
  68. +
  69. // Updates the Accept-Language header to be used for requests.
  70. SetAcceptLanguage(string new_accept_language);
  71. diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
  72. index f233265ccc0be9b412bf2e3e702e12614fa435c4..51006ddb52a0c4c4ea9f1cdb631cf4d75967bb66 100644
  73. --- a/services/network/test/test_network_context.h
  74. +++ b/services/network/test/test_network_context.h
  75. @@ -117,6 +117,7 @@ class TestNetworkContext : public mojom::NetworkContext {
  76. void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
  77. void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
  78. mojom::NetworkConditionsPtr conditions) override {}
  79. + void SetUserAgent(const std::string& new_user_agent) override {}
  80. void SetAcceptLanguage(const std::string& new_accept_language) override {}
  81. void SetEnableReferrers(bool enable_referrers) override {}
  82. #if BUILDFLAG(IS_CHROMEOS_ASH)