make_include_of_stack_trace_h_unconditional.patch 968 B

123456789101112131415161718192021222324
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Samuel Attard <[email protected]>
  3. Date: Tue, 11 May 2021 20:41:00 -0700
  4. Subject: make include of stack_trace.h unconditional
  5. This conditional include throws goma for a loop for no real reason.
  6. While we work on either upstreaming this or fixing the underlying goma
  7. issue this makes our builds 33% faster during local testing (11m vs 18m).
  8. diff --git a/base/sequence_checker.h b/base/sequence_checker.h
  9. index 50a548a759c2dc6d79978741a0c803500d53a9f8..cd5049e8bf59c51b890bcc332f9a1c5f0ec339c9 100644
  10. --- a/base/sequence_checker.h
  11. +++ b/base/sequence_checker.h
  12. @@ -10,9 +10,8 @@
  13. #include "base/strings/string_piece.h"
  14. #include "build/build_config.h"
  15. -#if DCHECK_IS_ON()
  16. #include "base/debug/stack_trace.h"
  17. -#endif
  18. +
  19. // SequenceChecker is a helper class used to help verify that some methods of a
  20. // class are called sequentially (for thread-safety). It supports thread safety