12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Deepak Mohan <[email protected]>
- Date: Fri, 28 Feb 2020 15:08:26 -0800
- Subject: gpu: notify when dxdiag request for gpu info fails
- We rely on the signal OnGpuInfoUpdate to process gpu info.
- When Electron wants to collect the complete info in a single run
- it checks for the presence of dx_diagnostics attribute, as these
- are the only async calls that happens in the gpu process, but
- there are times when this call can fail due to crash or software
- rendering and there is no signal from browser process on this event
- to identify it.
- diff --git a/content/browser/gpu/gpu_data_manager_impl.cc b/content/browser/gpu/gpu_data_manager_impl.cc
- index b55ab1c2e4172b069ee9f0a7dbce3b8a64cfe6da..19c138929e28bd155c1c510bbd1abc2712b6a29e 100644
- --- a/content/browser/gpu/gpu_data_manager_impl.cc
- +++ b/content/browser/gpu/gpu_data_manager_impl.cc
- @@ -229,6 +229,11 @@ void GpuDataManagerImpl::TerminateInfoCollectionGpuProcess() {
- base::AutoLock auto_lock(lock_);
- private_->TerminateInfoCollectionGpuProcess();
- }
- +
- +bool GpuDataManagerImpl::DxdiagDx12VulkanRequested() const {
- + base::AutoLock auto_lock(lock_);
- + return private_->DxdiagDx12VulkanRequested();
- +}
- #endif
-
- void GpuDataManagerImpl::UpdateDawnInfo(
- diff --git a/content/browser/gpu/gpu_data_manager_impl.h b/content/browser/gpu/gpu_data_manager_impl.h
- index 008795fbdc8724931852399704a945563fd0b3f2..6b295d21deebf59a79a205ef2fa8579d689a7c72 100644
- --- a/content/browser/gpu/gpu_data_manager_impl.h
- +++ b/content/browser/gpu/gpu_data_manager_impl.h
- @@ -115,6 +115,7 @@ class CONTENT_EXPORT GpuDataManagerImpl : public GpuDataManager,
- // BrowserMainParts override instead.
- void PostCreateThreads();
- void TerminateInfoCollectionGpuProcess();
- + bool DxdiagDx12VulkanRequested() const;
- #endif
- void UpdateDawnInfo(const std::vector<std::string>& dawn_info_list);
-
- diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
- index b7ad87a73ce1e7da9ea2a7b2557d97ebe1f84298..cb8197061cb1424d533d17cad3e22cb8b30c0a34 100644
- --- a/content/browser/gpu/gpu_data_manager_impl_private.cc
- +++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
- @@ -1108,6 +1108,12 @@ void GpuDataManagerImplPrivate::TerminateInfoCollectionGpuProcess() {
- if (host)
- host->ForceShutdown();
- }
- +
- +bool GpuDataManagerImplPrivate::DxdiagDx12VulkanRequested() const {
- + return !(gpu_info_vulkan_request_failed_ ||
- + gpu_info_dx12_request_failed_ ||
- + gpu_info_dx_diag_request_failed_);
- +}
- #endif
-
- void GpuDataManagerImplPrivate::UpdateDawnInfo(
- diff --git a/content/browser/gpu/gpu_data_manager_impl_private.h b/content/browser/gpu/gpu_data_manager_impl_private.h
- index b4256db01335ec312fd6be0060bc2ad4ee496ae6..b028d8feffe05ef37a8e5f16e35c2da3a5a1cc33 100644
- --- a/content/browser/gpu/gpu_data_manager_impl_private.h
- +++ b/content/browser/gpu/gpu_data_manager_impl_private.h
- @@ -79,6 +79,7 @@ class CONTENT_EXPORT GpuDataManagerImplPrivate {
- bool VulkanRequested() const;
- void PostCreateThreads();
- void TerminateInfoCollectionGpuProcess();
- + bool DxdiagDx12VulkanRequested() const;
- #endif
- void UpdateDawnInfo(const std::vector<std::string>& dawn_info_list);
-
|