Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: de679a181a
Branches Tags
electron
/
patches
/
chromium
/
feat_add_onclose_to_messageport.patch

feat_add_onclose_to_messageport.patch 2.5 KB
History Raw

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Jeremy Apthorp <[email protected]>
    3. 

  3. Date: Wed, 4 Mar 2020 11:18:03 -0800
    4. 

  4. Subject: feat: add onclose to MessagePort
    5. 

  5. 

  6. This adds the 'onclose' event to MessagePort. This is
    7. 

  7. [proposed](https://github.com/w3ctag/design-reviews/issues/269#issuecomment-407584290)
    8. 

  8. in w3c and has been discussed for years without conclusion. I'd like to
    9. 

  9. get this standardised, but in lieu of that, this makes MessagePort a
    10. 

  10. whole bunch more useful!
    11. 

  11. 

  12. diff --git a/third_party/blink/renderer/core/messaging/message_port.cc b/third_party/blink/renderer/core/messaging/message_port.cc
    13. 

  13. index c5714d115210488cb531c1e54de540f429636638..6f67b21803fcdc2498ef207878d1541e04822fca 100644
    14. 

  14. --- a/third_party/blink/renderer/core/messaging/message_port.cc
    15. 

  15. +++ b/third_party/blink/renderer/core/messaging/message_port.cc
    16. 

  16. @@ -161,6 +161,7 @@ void MessagePort::close() {
    17. 

  17.      Entangle(pipe.TakePort0());
    18. 

  18.    }
    19. 

  19.    closed_ = true;
    20. 

  20. +  DispatchEvent(*Event::Create(event_type_names::kClose));
    21. 

  21.  }
    22. 

  22.  
    23. 

  23.  void MessagePort::Entangle(MessagePortDescriptor port) {
    24. 

  24. diff --git a/third_party/blink/renderer/core/messaging/message_port.h b/third_party/blink/renderer/core/messaging/message_port.h
    25. 

  25. index 7a83dce5113dc77d3654997db09ff9bc4cfeb3e2..85987f99ee144060cee11719726eb823bf58c645 100644
    26. 

  26. --- a/third_party/blink/renderer/core/messaging/message_port.h
    27. 

  27. +++ b/third_party/blink/renderer/core/messaging/message_port.h
    28. 

  28. @@ -120,6 +120,13 @@ class CORE_EXPORT MessagePort : public EventTargetWithInlineData,
    29. 

  29.      return GetAttributeEventListener(event_type_names::kMessageerror);
    30. 

  30.    }
    31. 

  31.  
    32. 

  32. +  void setOnclose(EventListener* listener) {
    33. 

  33. +    SetAttributeEventListener(event_type_names::kClose, listener);
    34. 

  34. +  }
    35. 

  35. +  EventListener* onclose() {
    36. 

  36. +    return GetAttributeEventListener(event_type_names::kClose);
    37. 

  37. +  }
    38. 

  38. +
    39. 

  39.    // A port starts out its life entangled, and remains entangled until it is
    40. 

  40.    // closed or is cloned.
    41. 

  41.    bool IsEntangled() const { return !closed_ && !IsNeutered(); }
    42. 

  42. diff --git a/third_party/blink/renderer/core/messaging/message_port.idl b/third_party/blink/renderer/core/messaging/message_port.idl
    43. 

  43. index 6fab27fcdf1c333739b6ffe88b3cc4eed3301ee4..3f1f181d9b8a66997136f870f55c97c08294b6eb 100644
    44. 

  44. --- a/third_party/blink/renderer/core/messaging/message_port.idl
    45. 

  45. +++ b/third_party/blink/renderer/core/messaging/message_port.idl
    46. 

  46. @@ -40,4 +40,5 @@
    47. 

  47.      // event handlers
    48. 

  48.      attribute EventHandler onmessage;
    49. 

  49.      attribute EventHandler onmessageerror;
    50. 

  50. +    attribute EventHandler onclose;
    51. 

  51.  };
    52.