123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Jeremy Apthorp <[email protected]>
- Date: Wed, 28 Aug 2019 12:21:25 -0700
- Subject: expose SetUserAgent on NetworkContext
- Applying
- https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
- it's merged. There may end up being a better way of doing this, or the
- patch may be merged upstream, at which point this patch should be
- removed.
- diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
- index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a289703d8b0577 100644
- --- a/net/url_request/static_http_user_agent_settings.h
- +++ b/net/url_request/static_http_user_agent_settings.h
- @@ -26,13 +26,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
- accept_language_ = new_accept_language;
- }
-
- + void set_user_agent(const std::string& new_user_agent) {
- + user_agent_ = new_user_agent;
- + }
- +
- // HttpUserAgentSettings implementation
- std::string GetAcceptLanguage() const override;
- std::string GetUserAgent() const override;
-
- private:
- std::string accept_language_;
- - const std::string user_agent_;
- + std::string user_agent_;
-
- DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings);
- };
- diff --git a/services/network/network_context.cc b/services/network/network_context.cc
- index 83fde65c34f12fee6b2ef867f94fdd31252b60cf..c5012949a034f12ca466f5e5e791a1f4569d813f 100644
- --- a/services/network/network_context.cc
- +++ b/services/network/network_context.cc
- @@ -1195,6 +1195,13 @@ void NetworkContext::SetNetworkConditions(
- std::move(network_conditions));
- }
-
- +void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
- + // This may only be called on NetworkContexts created with a constructor that
- + // calls ApplyContextParamsToBuilder.
- + DCHECK(user_agent_settings_);
- + user_agent_settings_->set_user_agent(new_user_agent);
- +}
- +
- void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
- // This may only be called on NetworkContexts created with the constructor
- // that calls MakeURLRequestContext().
- diff --git a/services/network/network_context.h b/services/network/network_context.h
- index 1f09e757f9ac7f9f101066beddbd2f540cfd5b7d..43b461c1fa12ed38975a90a08987620088236dad 100644
- --- a/services/network/network_context.h
- +++ b/services/network/network_context.h
- @@ -255,6 +255,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
- void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
- void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
- mojom::NetworkConditionsPtr conditions) override;
- + void SetUserAgent(const std::string& new_user_agent) override;
- void SetAcceptLanguage(const std::string& new_accept_language) override;
- void SetEnableReferrers(bool enable_referrers) override;
- #if BUILDFLAG(IS_CHROMEOS_ASH)
- diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
- index 5dfc30d2feb37f78dd6eac088366a0dc3e1cf8e4..1da7a1d0103057df3b95f472f3b98c22d081fd8c 100644
- --- a/services/network/public/mojom/network_context.mojom
- +++ b/services/network/public/mojom/network_context.mojom
- @@ -957,6 +957,9 @@ interface NetworkContext {
- SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
- NetworkConditions? conditions);
-
- + // Updates the user agent to be used for requests.
- + SetUserAgent(string new_user_agent);
- +
- // Updates the Accept-Language header to be used for requests.
- SetAcceptLanguage(string new_accept_language);
-
- diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
- index 0d928e7db97bcc2ac99eea0e46a2f0b8405ddfb9..b325c08a447abb2424f08fb11abe2b1375e4b920 100644
- --- a/services/network/test/test_network_context.h
- +++ b/services/network/test/test_network_context.h
- @@ -123,6 +123,7 @@ class TestNetworkContext : public mojom::NetworkContext {
- void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
- void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
- mojom::NetworkConditionsPtr conditions) override {}
- + void SetUserAgent(const std::string& new_user_agent) override {}
- void SetAcceptLanguage(const std::string& new_accept_language) override {}
- void SetEnableReferrers(bool enable_referrers) override {}
- #if BUILDFLAG(IS_CHROMEOS_ASH)
|