123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Andy Locascio <[email protected]>
- Date: Wed, 6 May 2020 16:37:54 -0700
- Subject: allow in-process windows to have different web prefs
- Allow earlier access to newly created WebContents so that we can change
- WebPreferences of in-process child windows, rather than relying on
- process-level command line switches, as before.
- diff --git a/third_party/blink/common/web_preferences/web_preferences.cc b/third_party/blink/common/web_preferences/web_preferences.cc
- index 8a1315f7f89588bb21c6d3c21a7de7c07fed9679..51cc790f7e1ba1440a6ffaa56c9e01687fc35c06 100644
- --- a/third_party/blink/common/web_preferences/web_preferences.cc
- +++ b/third_party/blink/common/web_preferences/web_preferences.cc
- @@ -148,6 +148,22 @@ WebPreferences::WebPreferences()
- fake_no_alloc_direct_call_for_testing_enabled(false),
- v8_cache_options(blink::mojom::V8CacheOptions::kDefault),
- record_whole_document(false),
- + // Begin Electron-specific WebPreferences.
- + opener_id(0),
- + context_isolation(false),
- + guest_instance_id(0),
- + hidden_page(false),
- + offscreen(false),
- + preload(base::FilePath::StringType()),
- + native_window_open(false),
- + node_integration(false),
- + node_integration_in_worker(false),
- + node_integration_in_sub_frames(false),
- + enable_spellcheck(false),
- + enable_plugins(false),
- + enable_websql(false),
- + webview_tag(false),
- + // End Electron-specific WebPreferences.
- cookie_enabled(true),
- accelerated_video_decode_enabled(false),
- animation_policy(
- diff --git a/third_party/blink/common/web_preferences/web_preferences_mojom_traits.cc b/third_party/blink/common/web_preferences/web_preferences_mojom_traits.cc
- index a264ef99beb81dd6b1f55c1b0f57f6055b4ab771..ff4d5c5245ba0641b4ef02cdaf5d50be537b709e 100644
- --- a/third_party/blink/common/web_preferences/web_preferences_mojom_traits.cc
- +++ b/third_party/blink/common/web_preferences/web_preferences_mojom_traits.cc
- @@ -23,6 +23,10 @@ bool StructTraits<blink::mojom::WebPreferencesDataView,
- !data.ReadCursiveFontFamilyMap(&out->cursive_font_family_map) ||
- !data.ReadFantasyFontFamilyMap(&out->fantasy_font_family_map) ||
- !data.ReadPictographFontFamilyMap(&out->pictograph_font_family_map) ||
- + // Begin Electron-specific WebPreferences.
- + !data.ReadPreloads(&out->preloads) ||
- + !data.ReadPreload(&out->preload) ||
- + // End Electron-specific WebPreferences.
- !data.ReadLazyFrameLoadingDistanceThresholdsPx(
- &out->lazy_frame_loading_distance_thresholds_px) ||
- !data.ReadLazyImageLoadingDistanceThresholdsPx(
- @@ -156,6 +160,21 @@ bool StructTraits<blink::mojom::WebPreferencesDataView,
- data.fake_no_alloc_direct_call_for_testing_enabled();
- out->v8_cache_options = data.v8_cache_options();
- out->record_whole_document = data.record_whole_document();
- + // Begin Electron-specific WebPreferences.
- + out->opener_id = data.opener_id();
- + out->context_isolation = data.context_isolation();
- + out->guest_instance_id = data.guest_instance_id();
- + out->hidden_page = data.hidden_page();
- + out->offscreen = data.offscreen();
- + out->native_window_open = data.native_window_open();
- + out->node_integration = data.node_integration();
- + out->node_integration_in_worker = data.node_integration_in_worker();
- + out->node_integration_in_sub_frames = data.node_integration_in_sub_frames();
- + out->enable_spellcheck = data.enable_spellcheck();
- + out->enable_plugins = data.enable_plugins();
- + out->enable_websql = data.enable_websql();
- + out->webview_tag = data.webview_tag();
- + // End Electron-specific WebPreferences.s
- out->cookie_enabled = data.cookie_enabled();
- out->accelerated_video_decode_enabled =
- data.accelerated_video_decode_enabled();
- diff --git a/third_party/blink/public/common/web_preferences/web_preferences.h b/third_party/blink/public/common/web_preferences/web_preferences.h
- index 4517bf43c1b80f1aa0f3ba8e67e78b8b91e19f8a..492f6c948af74bb925826a1075e6343f147f0eb2 100644
- --- a/third_party/blink/public/common/web_preferences/web_preferences.h
- +++ b/third_party/blink/public/common/web_preferences/web_preferences.h
- @@ -10,6 +10,7 @@
- #include <vector>
-
- #include "build/build_config.h"
- +#include "base/files/file_path.h"
- #include "net/nqe/effective_connection_type.h"
- #include "third_party/blink/public/common/common_export.h"
- #include "third_party/blink/public/mojom/css/preferred_color_scheme.mojom-shared.h"
- @@ -162,6 +163,24 @@ struct BLINK_COMMON_EXPORT WebPreferences {
- blink::mojom::V8CacheOptions v8_cache_options;
- bool record_whole_document;
-
- + // Begin Electron-specific WebPreferences.
- + std::vector<base::FilePath> preloads;
- + int opener_id;
- + bool context_isolation;
- + int guest_instance_id;
- + bool hidden_page;
- + bool offscreen;
- + base::FilePath preload;
- + bool native_window_open;
- + bool node_integration;
- + bool node_integration_in_worker;
- + bool node_integration_in_sub_frames;
- + bool enable_spellcheck;
- + bool enable_plugins;
- + bool enable_websql;
- + bool webview_tag;
- + // End Electron-specific WebPreferences.
- +
- // This flags corresponds to a Page's Settings' setCookieEnabled state. It
- // only controls whether or not the "document.cookie" field is properly
- // connected to the backing store, for instance if you wanted to be able to
- diff --git a/third_party/blink/public/common/web_preferences/web_preferences_mojom_traits.h b/third_party/blink/public/common/web_preferences/web_preferences_mojom_traits.h
- index 9dbbb581a8876430c3e0a39df1ff655d3ddc6d2d..fd6cbcfa1992a75bf660fb9eb47a9099acb3834f 100644
- --- a/third_party/blink/public/common/web_preferences/web_preferences_mojom_traits.h
- +++ b/third_party/blink/public/common/web_preferences/web_preferences_mojom_traits.h
- @@ -6,6 +6,7 @@
- #define THIRD_PARTY_BLINK_PUBLIC_COMMON_WEB_PREFERENCES_WEB_PREFERENCES_MOJOM_TRAITS_H_
-
- #include "build/build_config.h"
- +#include "mojo/public/cpp/base/file_path_mojom_traits.h"
- #include "mojo/public/cpp/bindings/struct_traits.h"
- #include "net/nqe/effective_connection_type.h"
- #include "third_party/blink/public/common/common_export.h"
- @@ -451,6 +452,68 @@ struct BLINK_COMMON_EXPORT StructTraits<blink::mojom::WebPreferencesDataView,
- return r.record_whole_document;
- }
-
- + // Begin Electron-specific WebPreferences.
- + static const std::vector<base::FilePath>& preloads(const blink::web_pref::WebPreferences& r) {
- + return r.preloads;
- + }
- +
- + static int opener_id(const blink::web_pref::WebPreferences& r) {
- + return r.opener_id;
- + }
- +
- + static bool context_isolation(const blink::web_pref::WebPreferences& r) {
- + return r.context_isolation;
- + }
- +
- + static int guest_instance_id(const blink::web_pref::WebPreferences& r) {
- + return r.guest_instance_id;
- + }
- +
- + static bool hidden_page(const blink::web_pref::WebPreferences& r) {
- + return r.hidden_page;
- + }
- +
- + static bool offscreen(const blink::web_pref::WebPreferences& r) {
- + return r.offscreen;
- + }
- +
- + static const base::FilePath& preload(const blink::web_pref::WebPreferences& r) {
- + return r.preload;
- + }
- +
- + static bool native_window_open(const blink::web_pref::WebPreferences& r) {
- + return r.native_window_open;
- + }
- +
- + static bool node_integration(const blink::web_pref::WebPreferences& r) {
- + return r.node_integration;
- + }
- +
- + static bool node_integration_in_worker(const blink::web_pref::WebPreferences& r) {
- + return r.node_integration_in_worker;
- + }
- +
- + static bool node_integration_in_sub_frames(const blink::web_pref::WebPreferences& r) {
- + return r.node_integration_in_sub_frames;
- + }
- +
- + static bool enable_spellcheck(const blink::web_pref::WebPreferences& r) {
- + return r.enable_spellcheck;
- + }
- +
- + static bool enable_plugins(const blink::web_pref::WebPreferences& r) {
- + return r.enable_plugins;
- + }
- +
- + static bool enable_websql(const blink::web_pref::WebPreferences& r) {
- + return r.enable_websql;
- + }
- +
- + static bool webview_tag(const blink::web_pref::WebPreferences& r) {
- + return r.webview_tag;
- + }
- + // End Electron-specific WebPreferences.
- +
- static bool cookie_enabled(const blink::web_pref::WebPreferences& r) {
- return r.cookie_enabled;
- }
- diff --git a/third_party/blink/public/mojom/webpreferences/web_preferences.mojom b/third_party/blink/public/mojom/webpreferences/web_preferences.mojom
- index eaecb8c2b7dadaf7650bc8ac85cbad4383035e67..7863c865df17fa95965b5a4e543579bac22af90b 100644
- --- a/third_party/blink/public/mojom/webpreferences/web_preferences.mojom
- +++ b/third_party/blink/public/mojom/webpreferences/web_preferences.mojom
- @@ -10,6 +10,7 @@ import "third_party/blink/public/mojom/v8_cache_options.mojom";
- import "url/mojom/url.mojom";
- import "url/mojom/origin.mojom";
- import "mojo/public/mojom/base/string16.mojom";
- +import "mojo/public/mojom/base/file_path.mojom";
-
- enum PointerType {
- kPointerNone = 1, // 1 << 0
- @@ -214,6 +215,24 @@ struct WebPreferences {
- V8CacheOptions v8_cache_options;
- bool record_whole_document;
-
- + // Begin Electron-specific WebPreferences.
- + array<mojo_base.mojom.FilePath> preloads;
- + int32 opener_id;
- + bool context_isolation;
- + int32 guest_instance_id;
- + bool hidden_page;
- + bool offscreen;
- + mojo_base.mojom.FilePath preload;
- + bool native_window_open;
- + bool node_integration;
- + bool node_integration_in_worker;
- + bool node_integration_in_sub_frames;
- + bool enable_spellcheck;
- + bool enable_plugins;
- + bool enable_websql;
- + bool webview_tag;
- + // End Electron-specific WebPreferences.
- +
- // This flags corresponds to a Page's Settings' setCookieEnabled state. It
- // only controls whether or not the "document.cookie" field is properly
- // connected to the backing store, for instance if you wanted to be able to
|