expose_setuseragent_on_networkcontext.patch 4.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Wed, 28 Aug 2019 12:21:25 -0700
  4. Subject: expose SetUserAgent on NetworkContext
  5. Applying
  6. https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
  7. it's merged. There may end up being a better way of doing this, or the
  8. patch may be merged upstream, at which point this patch should be
  9. removed.
  10. diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
  11. index 0ab8187b0db8ae6db46d81738f653a2bc4c566f6..de3d55e85c22317f7f9375eb94d0d5d41b0dbd3b 100644
  12. --- a/net/url_request/static_http_user_agent_settings.h
  13. +++ b/net/url_request/static_http_user_agent_settings.h
  14. @@ -30,13 +30,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
  15. accept_language_ = new_accept_language;
  16. }
  17. + void set_user_agent(const std::string& new_user_agent) {
  18. + user_agent_ = new_user_agent;
  19. + }
  20. +
  21. // HttpUserAgentSettings implementation
  22. std::string GetAcceptLanguage() const override;
  23. std::string GetUserAgent() const override;
  24. private:
  25. std::string accept_language_;
  26. - const std::string user_agent_;
  27. + std::string user_agent_;
  28. };
  29. } // namespace net
  30. diff --git a/services/network/network_context.cc b/services/network/network_context.cc
  31. index e346cfb127a1fa8656bfbc1eba829907e19bc22f..e18583e520b4ab66110605b67c703a1c48b770a4 100644
  32. --- a/services/network/network_context.cc
  33. +++ b/services/network/network_context.cc
  34. @@ -1810,6 +1810,13 @@ void NetworkContext::SetNetworkConditions(
  35. std::move(network_conditions));
  36. }
  37. +void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
  38. + // This may only be called on NetworkContexts created with a constructor that
  39. + // calls ApplyContextParamsToBuilder.
  40. + DCHECK(user_agent_settings_);
  41. + user_agent_settings_->set_user_agent(new_user_agent);
  42. +}
  43. +
  44. void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
  45. // This may only be called on NetworkContexts created with the constructor
  46. // that calls MakeURLRequestContext().
  47. diff --git a/services/network/network_context.h b/services/network/network_context.h
  48. index fe04f634b32e503f6e93ae6f20c8c7f7c85d02be..990df479da79b513cf8797aa2fcacba10c4fbbd9 100644
  49. --- a/services/network/network_context.h
  50. +++ b/services/network/network_context.h
  51. @@ -317,6 +317,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
  52. void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
  53. void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
  54. mojom::NetworkConditionsPtr conditions) override;
  55. + void SetUserAgent(const std::string& new_user_agent) override;
  56. void SetAcceptLanguage(const std::string& new_accept_language) override;
  57. void SetEnableReferrers(bool enable_referrers) override;
  58. #if BUILDFLAG(IS_CT_SUPPORTED)
  59. diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
  60. index e928d012d77ccffe16263fd0ee7c2769adfe4bac..1be1b691fa240fa3c5e2c572821977a968841211 100644
  61. --- a/services/network/public/mojom/network_context.mojom
  62. +++ b/services/network/public/mojom/network_context.mojom
  63. @@ -1253,6 +1253,9 @@ interface NetworkContext {
  64. SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
  65. NetworkConditions? conditions);
  66. + // Updates the user agent to be used for requests.
  67. + SetUserAgent(string new_user_agent);
  68. +
  69. // Updates the Accept-Language header to be used for requests.
  70. SetAcceptLanguage(string new_accept_language);
  71. diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
  72. index 97e8f9f145cecad9b0cd8b43a2de4af29cec7778..b9539a731d2252c8301d51ccb7a1bd7b1a23ca53 100644
  73. --- a/services/network/test/test_network_context.h
  74. +++ b/services/network/test/test_network_context.h
  75. @@ -156,6 +156,7 @@ class TestNetworkContext : public mojom::NetworkContext {
  76. void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
  77. void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
  78. mojom::NetworkConditionsPtr conditions) override {}
  79. + void SetUserAgent(const std::string& new_user_agent) override {}
  80. void SetAcceptLanguage(const std::string& new_accept_language) override {}
  81. void SetEnableReferrers(bool enable_referrers) override {}
  82. #if BUILDFLAG(IS_CT_SUPPORTED)