build_gn.patch 1.3 KB

12345678910111213141516171819202122232425262728293031323334353637383940
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Tue, 16 Apr 2019 10:43:04 -0700
  4. Subject: build_gn.patch
  5. We force V8 into 'shared library' mode so that it exports its symbols, which is
  6. necessary for native modules to load.
  7. Also change visibility on mksnapshot in order to target mksnapshot for mksnapshot zip.
  8. diff --git a/BUILD.gn b/BUILD.gn
  9. index ca081a790959d22b12f10e9c08f9acbc339e7ed7..06465300718a74d089c2281f60bb63735657e3bd 100644
  10. --- a/BUILD.gn
  11. +++ b/BUILD.gn
  12. @@ -739,7 +739,7 @@ config("internal_config") {
  13. ":cppgc_header_features",
  14. ]
  15. - if (is_component_build) {
  16. + if (is_component_build || is_electron_build) {
  17. defines += [ "BUILDING_V8_SHARED" ]
  18. }
  19. @@ -6711,7 +6711,7 @@ if (current_toolchain == v8_generator_toolchain) {
  20. "src/interpreter/bytecodes.h",
  21. ]
  22. - configs = [ ":internal_config" ]
  23. + configs = [ ":internal_config_base" ]
  24. deps = [
  25. ":v8_libbase",
  26. @@ -6723,7 +6723,6 @@ if (current_toolchain == v8_generator_toolchain) {
  27. if (current_toolchain == v8_snapshot_toolchain) {
  28. v8_executable("mksnapshot") {
  29. - visibility = [ ":*" ] # Only targets in this file can depend on this.
  30. sources = [
  31. "src/snapshot/embedded/embedded-empty.cc",