Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: c3036d4557
Branches Tags
electron
/
patches
/
chromium
/
fix_allow_guest_webcontents_to_enter_fullscreen.patch

fix_allow_guest_webcontents_to_enter_fullscreen.patch 1.2 KB
History Raw

1234567891011121314151617181920 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Samuel Attard <[email protected]>
    3. 

  3. Date: Mon, 6 Jun 2022 14:25:15 -0700
    4. 

  4. Subject: fix: allow guest webcontents to enter fullscreen
    5. 

  5. 

  6. This can be upstreamed, a guest webcontents can't technically become the focused webContents. This DCHECK should allow all guest webContents to request fullscreen entrance.
    7. 

  7. 

  8. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
    9. 

  9. index 3fef597d18025bd35b4f7af105c6907602958223..a515cff65ec418ccd44bccd61b0cf8094cb864db 100644
    10. 

  10. --- a/content/browser/web_contents/web_contents_impl.cc
    11. 

  11. +++ b/content/browser/web_contents/web_contents_impl.cc
    12. 

  12. @@ -3714,7 +3714,7 @@ void WebContentsImpl::EnterFullscreenMode(
    13. 

  13.    OPTIONAL_TRACE_EVENT0("content", "WebContentsImpl::EnterFullscreenMode");
    14. 

  14.    DCHECK(CanEnterFullscreenMode(requesting_frame, options));
    15. 

  15.    DCHECK(requesting_frame->IsActive());
    16. 

  16. -  DCHECK(ContainsOrIsFocusedWebContents());
    17. 

  17. +  DCHECK(ContainsOrIsFocusedWebContents() || IsGuest());
    18. 

  18.  
    19. 

  19.    // When WebView is the `delegate_` we can end up with VisualProperties changes
    20. 

  20.    // synchronously. Notify the view ahead so it can handle the transition.
    21.