123456789101112131415161718192021222324252627282930313233 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Samuel Attard <[email protected]>
- Date: Mon, 8 Mar 2021 16:27:39 -0800
- Subject: extend ApplyWebPreferences with Electron-specific logic
- background_color can be updated at runtime, as such we need to apply the
- new background color to the WebView in the ApplyPreferences method.
- There is no current way to attach an observer to these prefs so patching
- is our only option.
- Ideally we could add an embedder observer pattern here but that can be
- done in future work.
- diff --git a/third_party/blink/renderer/core/exported/web_view_impl.cc b/third_party/blink/renderer/core/exported/web_view_impl.cc
- index c724ee69385ae9817161a72f82a14c4ac9b5f835..625a40b764a1cc7eb6f89a7e30a6172861c41cc4 100644
- --- a/third_party/blink/renderer/core/exported/web_view_impl.cc
- +++ b/third_party/blink/renderer/core/exported/web_view_impl.cc
- @@ -165,6 +165,7 @@
- #include "third_party/blink/renderer/core/view_transition/view_transition_supplement.h"
- #include "third_party/blink/renderer/platform/fonts/font_cache.h"
- #include "third_party/blink/renderer/platform/fonts/generic_font_family_settings.h"
- +#include "third_party/blink/renderer/platform/graphics/color.h"
- #include "third_party/blink/renderer/platform/graphics/image.h"
- #include "third_party/blink/renderer/platform/graphics/paint/cull_rect.h"
- #include "third_party/blink/renderer/platform/graphics/paint/paint_record_builder.h"
- @@ -1785,6 +1786,7 @@ void WebView::ApplyWebPreferences(const web_pref::WebPreferences& prefs,
- #if BUILDFLAG(IS_MAC)
- web_view_impl->SetMaximumLegibleScale(
- prefs.default_maximum_page_scale_factor);
- + SetUseExternalPopupMenus(!prefs.offscreen);
- #endif
-
- #if BUILDFLAG(IS_WIN)
|