fix_allow_guest_webcontents_to_enter_fullscreen.patch 1.1 KB

1234567891011121314151617181920
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Samuel Attard <[email protected]>
  3. Date: Mon, 6 Jun 2022 14:25:15 -0700
  4. Subject: fix: allow guest webcontents to enter fullscreen
  5. This can be upstreamed, a guest webcontents can't technically become the focused webContents. This DCHECK should allow all guest webContents to request fullscreen entrance.
  6. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
  7. index d5af52091f201cc51c3525798d99e2e42f623979..dfb2ac1c515176c12f7f39d08b671321f6a931b4 100644
  8. --- a/content/browser/web_contents/web_contents_impl.cc
  9. +++ b/content/browser/web_contents/web_contents_impl.cc
  10. @@ -3460,7 +3460,7 @@ void WebContentsImpl::EnterFullscreenMode(
  11. OPTIONAL_TRACE_EVENT0("content", "WebContentsImpl::EnterFullscreenMode");
  12. DCHECK(CanEnterFullscreenMode(requesting_frame, options));
  13. DCHECK(requesting_frame->IsActive());
  14. - DCHECK(ContainsOrIsFocusedWebContents());
  15. + DCHECK(ContainsOrIsFocusedWebContents() || IsGuest());
  16. if (delegate_) {
  17. delegate_->EnterFullscreenModeForTab(requesting_frame, options);