fix_account_for_createexternalizablestring_v8_global.patch 1.1 KB

1234567891011121314151617181920212223
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Tue, 23 May 2023 18:21:17 +0200
  4. Subject: fix: account for createExternalizableString V8 global
  5. Introduced in https://chromium-review.googlesource.com/c/v8/v8/+/4531903.
  6. This patch can be removed when Node.js upgrades to a version of V8 with the above
  7. CL - they'll need to make the same change.
  8. diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js
  9. index 59b83f531cf0a60f960d0096aea70854f45bd629..9dcc35987a4757ea090e81c7de38a6af5bc3182f 100644
  10. --- a/test/parallel/test-fs-write.js
  11. +++ b/test/parallel/test-fs-write.js
  12. @@ -38,7 +38,7 @@ const constants = fs.constants;
  13. const { externalizeString, isOneByteString } = global;
  14. // Account for extra globals exposed by --expose_externalize_string.
  15. -common.allowGlobals(externalizeString, isOneByteString, global.x);
  16. +common.allowGlobals(createExternalizableString, externalizeString, isOneByteString, global.x);
  17. {
  18. const expected = 'ümlaut sechzig'; // Must be a unique string.