chore_remove_use_of_deprecated_kmaxlength.patch 1.3 KB

1234567891011121314151617181920212223242526272829303132333435
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Charles Kerr <[email protected]>
  3. Date: Tue, 17 Oct 2023 10:58:41 -0500
  4. Subject: chore: remove use of deprecated kMaxLength
  5. https://chromium-review.googlesource.com/c/v8/v8/+/4935412
  6. This patch can be removed when upstream moves to kMaxByteLength
  7. diff --git a/src/node_buffer.h b/src/node_buffer.h
  8. index 606a6f5caa3b11b6d2a9068ed2fd65800530a5eb..080dcce21da05ccea398d8a856deb397b1ac8b07 100644
  9. --- a/src/node_buffer.h
  10. +++ b/src/node_buffer.h
  11. @@ -29,7 +29,7 @@ namespace node {
  12. namespace Buffer {
  13. -static const size_t kMaxLength = v8::TypedArray::kMaxLength;
  14. +static const size_t kMaxLength = v8::TypedArray::kMaxByteLength;
  15. typedef void (*FreeCallback)(char* data, void* hint);
  16. diff --git a/src/node_errors.h b/src/node_errors.h
  17. index 1662491bac44311421eeb7ee35bb47c025162abf..a62b18e832986ee38d93b412b36020a2c22255a9 100644
  18. --- a/src/node_errors.h
  19. +++ b/src/node_errors.h
  20. @@ -230,7 +230,7 @@ inline v8::Local<v8::Object> ERR_BUFFER_TOO_LARGE(v8::Isolate* isolate) {
  21. char message[128];
  22. snprintf(message, sizeof(message),
  23. "Cannot create a Buffer larger than 0x%zx bytes",
  24. - v8::TypedArray::kMaxLength);
  25. + v8::TypedArray::kMaxByteLength);
  26. return ERR_BUFFER_TOO_LARGE(isolate, message);
  27. }