fix_remove_harmony-import-assertions_from_node_cc.patch 1.0 KB

12345678910111213141516171819202122232425
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Fri, 18 Oct 2024 17:01:06 +0200
  4. Subject: fix: remove harmony-import-assertions from node.cc
  5. harmony-import-assertions has been removed from V8 as of
  6. https://chromium-review.googlesource.com/c/v8/v8/+/5507047,
  7. so we should remove it from node.cc as well.
  8. This patch can be removed when we upgrade to a V8 version that
  9. contains the above CL.
  10. diff --git a/src/node.cc b/src/node.cc
  11. index f4365c0eda7330bd02a921608951902f41004f77..b2b10ffb572f010992f221de752618fd56b5d50e 100644
  12. --- a/src/node.cc
  13. +++ b/src/node.cc
  14. @@ -808,7 +808,7 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
  15. }
  16. // TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default
  17. // anymore.
  18. - v8_args.emplace_back("--no-harmony-import-assertions");
  19. + // v8_args.emplace_back("--no-harmony-import-assertions");
  20. auto env_opts = per_process::cli_options->per_isolate->per_env;
  21. if (std::find(v8_args.begin(), v8_args.end(),