12345678910111213141516171819202122232425262728 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Charles Kerr <[email protected]>
- Date: Sat, 28 Sep 2024 17:33:51 -0500
- Subject: chore: partial revert of
- https://chromium-review.googlesource.com/c/chromium/src/+/5894233
- The `CHECK_EQ()` being removed here is failing in the Chromium roll.
- I experimented with backporting the `CHECK_EQ()` to `main` and it's
- failing there as well, so some pre-existing behavior in Electron is
- incompatible with this assertion.
- I will file an upgrades-followup-task issue in Electron and try to
- track down the source of this problem & figure out if we can fix it
- by changing something in Electron.
- diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
- index 8c805aec2042d7c02ba0a28f544feb6d976a0775..d5e8086df8b15f90acbea43f93706c2b9543a8ef 100644
- --- a/content/browser/web_contents/web_contents_impl.cc
- +++ b/content/browser/web_contents/web_contents_impl.cc
- @@ -4950,7 +4950,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
- : IsGuest();
- // While some guest types do not have a guest SiteInstance, the ones that
- // don't all override WebContents creation above.
- - CHECK_EQ(source_site_instance->IsGuest(), is_guest);
- + // CHECK_EQ(source_site_instance->IsGuest(), is_guest);
-
- // We usually create the new window in the same BrowsingInstance (group of
- // script-related windows), by passing in the current SiteInstance. However,
|