add_realloc.patch 1.8 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Mon, 22 Oct 2018 10:47:11 -0700
  4. Subject: add_realloc.patch
  5. Blink overrides ArrayBuffer's allocator with its own one, while Node simply
  6. uses malloc and free, so we need to use v8's allocator in Node. As part of the
  7. 10.6.0 upgrade, we needed to make SerializerDelegate accept an allocator
  8. argument in its constructor, and override ReallocateBufferMemory and
  9. FreeBufferMemory to use the allocator. We cannot simply allocate and then memcpy
  10. when we override ReallocateBufferMemory, so we therefore need to implement
  11. Realloc on the v8 side.
  12. diff --git a/include/v8.h b/include/v8.h
  13. index 9926b308b15cdaee4c76ad6d36adfb051ef9c480..484548864b75fff92172bfb231478c42bd4cf75d 100644
  14. --- a/include/v8.h
  15. +++ b/include/v8.h
  16. @@ -5041,6 +5041,13 @@ class V8_EXPORT ArrayBuffer : public Object {
  17. */
  18. virtual void* AllocateUninitialized(size_t length) = 0;
  19. + /**
  20. + * Free the memory block of size |length|, pointed to by |data|.
  21. + * That memory must be previously allocated by |Allocate| and not yet freed
  22. + * with a call to |Free| or |Realloc|
  23. + */
  24. + virtual void* Realloc(void* data, size_t length);
  25. +
  26. /**
  27. * Free the memory block of size |length|, pointed to by |data|.
  28. * That memory is guaranteed to be previously allocated by |Allocate|.
  29. diff --git a/src/api/api.cc b/src/api/api.cc
  30. index b2d6db3661a564d20f6d07a67bff627ba2ee75da..feda31f69bf53b392506bd87ac5d966b1e6b9329 100644
  31. --- a/src/api/api.cc
  32. +++ b/src/api/api.cc
  33. @@ -528,6 +528,10 @@ void V8::SetSnapshotDataBlob(StartupData* snapshot_blob) {
  34. i::V8::SetSnapshotBlob(snapshot_blob);
  35. }
  36. +void* v8::ArrayBuffer::Allocator::Realloc(void* data, size_t length) {
  37. + UNIMPLEMENTED();
  38. +}
  39. +
  40. namespace {
  41. class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {