chore_remove_calls_to_v8_functioncallbackinfo_holder.patch 1.0 KB

123456789101112131415161718192021222324
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: John Kleinschmidt <[email protected]>
  3. Date: Mon, 10 Jun 2024 11:18:56 -0500
  4. Subject: chore: remove calls to v8::FunctionCallbackInfo::Holder()
  5. Use This() instead.
  6. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5604487
  7. https://issues.chromium.org/issues/333672197
  8. This patch can be removed once Node addresses this change.
  9. diff --git a/src/node_internals.h b/src/node_internals.h
  10. index 5dff80ee287256ba40bfa496df6db60a18fbb9d7..a9162b4e2ee48dbebec8dc52b6990369be15fe4a 100644
  11. --- a/src/node_internals.h
  12. +++ b/src/node_internals.h
  13. @@ -67,7 +67,7 @@ template <typename T, int (*F)(const typename T::HandleType*, sockaddr*, int*)>
  14. void GetSockOrPeerName(const v8::FunctionCallbackInfo<v8::Value>& args) {
  15. T* wrap;
  16. ASSIGN_OR_RETURN_UNWRAP(&wrap,
  17. - args.Holder(),
  18. + args.This(),
  19. args.GetReturnValue().Set(UV_EBADF));
  20. CHECK(args[0]->IsObject());
  21. sockaddr_storage storage;