12345678910111213141516171819202122 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Samuel Attard <[email protected]>
- Date: Thu, 18 Oct 2018 17:07:47 -0700
- Subject: dump_syms.patch
- dylib currently fails to resolve Squirrel.framework on OSX, we need to fix
- this but it is not a blocker for releasing Electron. This patch removes
- the hard fail on dylib resolve failure from dump_syms
- diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py
- index dcf26b7200b3ceba1d17e8ea813f23b275e2d286..a367fa2bf31591c98dd4245d42a71cd9da82f2d9 100755
- --- a/components/crash/content/tools/generate_breakpad_symbols.py
- +++ b/components/crash/content/tools/generate_breakpad_symbols.py
- @@ -199,7 +199,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path):
- 'ERROR: failed to resolve %s, exe_path %s, loader_path %s, '
- 'rpaths %s' % (m.group(1), exe_path, loader_path,
- ', '.join(rpaths)))
- - sys.exit(1)
- + # sys.exit(1)
- return deps
-
-
|