build_gn.patch 1.2 KB

1234567891011121314151617181920212223242526272829303132333435363738394041
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Tue, 16 Apr 2019 10:43:04 -0700
  4. Subject: build_gn.patch
  5. We force V8 into 'shared library' mode so that it exports its symbols, which is
  6. necessary for native modules to load.
  7. Also, some fixes relating to mksnapshot on ARM.
  8. diff --git a/BUILD.gn b/BUILD.gn
  9. index 076b75e2e5b3465ab3115f7186296c34f59480fc..7eaa7582fc1efc2381c267fec96fe94d274f922b 100644
  10. --- a/BUILD.gn
  11. +++ b/BUILD.gn
  12. @@ -605,7 +605,7 @@ config("internal_config") {
  13. ":cppgc_header_features",
  14. ]
  15. - if (is_component_build) {
  16. + if (is_component_build || is_electron_build) {
  17. defines += [ "BUILDING_V8_SHARED" ]
  18. }
  19. @@ -5819,7 +5819,7 @@ if (current_toolchain == v8_generator_toolchain) {
  20. "src/interpreter/bytecodes.h",
  21. ]
  22. - configs = [ ":internal_config" ]
  23. + configs = [ ":internal_config_base" ]
  24. deps = [
  25. ":v8_libbase",
  26. @@ -5857,6 +5857,8 @@ if (current_toolchain == v8_snapshot_toolchain) {
  27. configs = [ ":internal_config" ]
  28. + configs += [ "//electron/build/config:build_time_executable" ]
  29. +
  30. deps = [
  31. ":v8_base_without_compiler",
  32. ":v8_compiler_for_mksnapshot",