include_string_in_v8_h.patch 1.0 KB

1234567891011121314151617181920212223242526272829
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jaime Bernardo <[email protected]>
  3. Date: Tue, 1 Oct 2019 20:06:03 +0100
  4. Subject: Include string in v8.h
  5. Explicitly #include<string> in v8.h, since std::string is referenced
  6. in it. In the C++ STL shipped with Visual Studio 2019, none of the
  7. headers included in v8.h ends up including the C++ string header, which
  8. caused a compile error.
  9. Bug: v8:9793
  10. Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df
  11. Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321
  12. Reviewed-by: Adam Klein <[email protected]>
  13. Commit-Queue: Adam Klein <[email protected]>
  14. Cr-Commit-Position: refs/heads/master@{#64074}
  15. diff --git a/include/v8.h b/include/v8.h
  16. index f5b6caaee19b7abb0ee4d98615988d1d8b14035c..36017a0a974ed6afd10c9df932e10812ed1e9769 100644
  17. --- a/include/v8.h
  18. +++ b/include/v8.h
  19. @@ -19,6 +19,7 @@
  20. #include <stdint.h>
  21. #include <stdio.h>
  22. #include <memory>
  23. +#include <string>
  24. #include <type_traits>
  25. #include <utility>
  26. #include <vector>