dump_syms.patch 1.0 KB

12345678910111213141516171819202122
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Samuel Attard <[email protected]>
  3. Date: Thu, 18 Oct 2018 17:07:47 -0700
  4. Subject: dump_syms.patch
  5. dylib currently fails to resolve Squirrel.framework on OSX, we need to fix
  6. this but it is not a blocker for releasing Electron. This patch removes
  7. the hard fail on dylib resolve failure from dump_syms
  8. diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py
  9. index cdd374c33a3edc12db9c9496a4ca765d2ba0ab5d..db04d39f8d263dc2b3b67b7f84470f557b519cfa 100755
  10. --- a/components/crash/content/tools/generate_breakpad_symbols.py
  11. +++ b/components/crash/content/tools/generate_breakpad_symbols.py
  12. @@ -175,7 +175,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path):
  13. 'ERROR: failed to resolve %s, exe_path %s, loader_path %s, '
  14. 'rpaths %s' % (m.group(1), exe_path, loader_path,
  15. ', '.join(rpaths)))
  16. - sys.exit(1)
  17. + # sys.exit(1)
  18. return deps