feat_allow_passing_of_objecttemplate_to_objecttemplatebuilder.patch 2.0 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: John Kleinschmidt <[email protected]>
  3. Date: Fri, 6 Oct 2023 14:15:20 -0400
  4. Subject: feat: allow passing of ObjectTemplate to ObjectTemplateBuilder
  5. https://chromium-review.googlesource.com/c/chromium/src/+/4905829 removed the
  6. ObjectTemplateBuilder constructor which allows passing in an ObjectTemplate.
  7. Electron needs this constructor, namely for gin_helper::Constructible
  8. objects.
  9. diff --git a/gin/object_template_builder.cc b/gin/object_template_builder.cc
  10. index 0e534259322a3200f0b42a5188c32aaff69ac9d0..d9ad61e61b7071118f298649d861a9193a2cff8c 100644
  11. --- a/gin/object_template_builder.cc
  12. +++ b/gin/object_template_builder.cc
  13. @@ -216,6 +216,13 @@ ObjectTemplateBuilder::ObjectTemplateBuilder(v8::Isolate* isolate,
  14. template_->SetInternalFieldCount(kNumberOfInternalFields);
  15. }
  16. +ObjectTemplateBuilder::ObjectTemplateBuilder(v8::Isolate* isolate,
  17. + const char* type_name,
  18. + v8::Local<v8::ObjectTemplate> tmpl)
  19. + : isolate_(isolate), type_name_(type_name), template_(tmpl) {
  20. + template_->SetInternalFieldCount(kNumberOfInternalFields);
  21. +}
  22. +
  23. ObjectTemplateBuilder::ObjectTemplateBuilder(
  24. const ObjectTemplateBuilder& other) = default;
  25. diff --git a/gin/object_template_builder.h b/gin/object_template_builder.h
  26. index 9d8f6e5de793ea419875d99a0b46898f2e40ead5..c803363b8050f4084c9250fce9b5b8b171082703 100644
  27. --- a/gin/object_template_builder.h
  28. +++ b/gin/object_template_builder.h
  29. @@ -46,6 +46,9 @@ class GIN_EXPORT ObjectTemplateBuilder {
  30. public:
  31. explicit ObjectTemplateBuilder(v8::Isolate* isolate);
  32. ObjectTemplateBuilder(v8::Isolate* isolate, const char* type_name);
  33. + ObjectTemplateBuilder(v8::Isolate* isolate,
  34. + const char* type_name,
  35. + v8::Local<v8::ObjectTemplate> tmpl);
  36. ObjectTemplateBuilder(const ObjectTemplateBuilder& other);
  37. ~ObjectTemplateBuilder();