build_run_reclient_cfg_generator_after_chrome.patch 2.3 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Samuel Attard <[email protected]>
  3. Date: Thu, 28 Dec 2023 17:09:08 +1300
  4. Subject: build: run reclient cfg generator after chrome
  5. We can't run our generator after chromes in gclient hooks so instead we patch
  6. their generator to run ours immediately after.
  7. This can't be upstreamed though may be replaceable later with some upstream refactors
  8. around reclient config generation.
  9. diff --git a/buildtools/reclient_cfgs/.gitignore b/buildtools/reclient_cfgs/.gitignore
  10. index 17103061c4752e6fcac07413dbf574e0c6fd6d39..848be71fa6dc81a64b7274b31d461f9dcc4697fc 100644
  11. --- a/buildtools/reclient_cfgs/.gitignore
  12. +++ b/buildtools/reclient_cfgs/.gitignore
  13. @@ -1,4 +1,5 @@
  14. /chromium-browser-clang/
  15. /python/
  16. +/nacl/
  17. /win-cross/
  18. reproxy.cfg
  19. diff --git a/buildtools/reclient_cfgs/configure_reclient_cfgs.py b/buildtools/reclient_cfgs/configure_reclient_cfgs.py
  20. index 128bda296c91eac5f0c2fcfeed0c553deb5514dd..f1e33d36810dba80a42608655beb27c6e197a888 100755
  21. --- a/buildtools/reclient_cfgs/configure_reclient_cfgs.py
  22. +++ b/buildtools/reclient_cfgs/configure_reclient_cfgs.py
  23. @@ -344,4 +344,13 @@ def main():
  24. if __name__ == "__main__":
  25. - sys.exit(main())
  26. + r = main()
  27. + if r != 0:
  28. + sys.exit(r)
  29. +
  30. + electron_script = os.path.join(CHROMIUM_SRC, 'third_party', 'engflow-reclient-configs', 'configure_reclient.py')
  31. + r = subprocess.call([sys.executable, electron_script, '--src_dir=src', '--force'])
  32. + if r != 0:
  33. + sys.exit(r)
  34. +
  35. + print('done')
  36. diff --git a/buildtools/reclient_cfgs/nacl/rewrapper_linux.cfg b/buildtools/reclient_cfgs/nacl/rewrapper_linux.cfg
  37. deleted file mode 100644
  38. index 0a0771da2d7ab44f13037c95f8b948cf9b8c663f..0000000000000000000000000000000000000000
  39. --- a/buildtools/reclient_cfgs/nacl/rewrapper_linux.cfg
  40. +++ /dev/null
  41. @@ -1,10 +0,0 @@
  42. -# use the same platform container image as build/config/siso/main.star
  43. -platform=container-image=docker://gcr.io/chops-public-images-prod/rbe/siso-chromium/linux@sha256:ef35d347f4a4a2d32b76fd908e66e96f59bf8ba7379fd5626548244c45343b2b,label:action_default=1
  44. -server_address=unix:///tmp/reproxy.sock
  45. -labels=type=compile,compiler=nacl,lang=cpp
  46. -exec_strategy=racing
  47. -inputs=native_client/toolchain/linux_x86/saigo_newlib/lib
  48. -dial_timeout=10m
  49. -canonicalize_working_dir=true
  50. -exec_timeout=2m
  51. -reclient_timeout=4m