Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: 48801be8e9
Branches Tags
electron
/
patches
/
chromium
/
fix_disabling_background_throttling_in_compositor.patch

fix_disabling_background_throttling_in_compositor.patch 3.6 KB
History Raw

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Michal Pichlinski <[email protected]>
    3. 

  3. Date: Thu, 15 Jun 2023 23:04:48 +0200
    4. 

  4. Subject: allow disabling throttling in the `viz::DisplayScheduler` per
    5. 

  5.  `ui::Compositor`
    6. 

  6. 

  7. In Chromium when the `viz::DisplayScheduler` is invisible it throttles
    8. 

  8. its work by dropping frame draws and swaps.
    9. 

  9. 

  10. This patch allows disbling this throttling by preventing transition to
    11. 

  11. invisible state of the `viz::DisplayScheduler` owned
    12. 

  12. by the `ui::Compositor`.
    13. 

  13. 

  14. diff --git a/ui/compositor/compositor.cc b/ui/compositor/compositor.cc
    15. 

  15. index 99657563e117d243af1466dd1d4ad736da85f1b9..13bf3608ab9b8f6753a9474b2ce4c0a8eda60d90 100644
    16. 

  16. --- a/ui/compositor/compositor.cc
    17. 

  17. +++ b/ui/compositor/compositor.cc
    18. 

  18. @@ -344,7 +344,8 @@ void Compositor::SetLayerTreeFrameSink(
    19. 

  19.    if (display_private_) {
    20. 

  20.      disabled_swap_until_resize_ = false;
    21. 

  21.      display_private_->Resize(size());
    22. 

  22. -    display_private_->SetDisplayVisible(host_->IsVisible());
    23. 

  23. +    // Invisible display is throttling itself.
    24. 

  24. +    display_private_->SetDisplayVisible(background_throttling_ ? host_->IsVisible() : true);
    25. 

  25.      display_private_->SetDisplayColorSpaces(display_color_spaces_);
    26. 

  26.      display_private_->SetDisplayColorMatrix(
    27. 

  27.          gfx::SkM44ToTransform(display_color_matrix_));
    28. 

  28. @@ -555,7 +556,9 @@ void Compositor::SetVisible(bool visible) {
    29. 

  29.    // updated then. We need to call this even if the visibility hasn't changed,
    30. 

  30.    // for the same reason.
    31. 

  31.    if (display_private_)
    32. 

  32. -    display_private_->SetDisplayVisible(visible);
    33. 

  33. +    // Invisible display is throttling itself.
    34. 

  34. +    display_private_->SetDisplayVisible(
    35. 

  35. +        background_throttling_ ? visible : true);
    36. 

  36.  
    37. 

  37.    if (changed) {
    38. 

  38.      observer_list_.Notify(&CompositorObserver::OnCompositorVisibilityChanged,
    39. 

  39. @@ -1008,6 +1011,15 @@ void Compositor::MaybeUpdateObserveBeginFrame() {
    40. 

  40.        host_begin_frame_observer_->GetBoundRemote());
    41. 

  41.  }
    42. 

  42.  
    43. 

  43. +void Compositor::SetBackgroundThrottling(bool background_throttling_enabled) {
    44. 

  44. +  background_throttling_ = background_throttling_enabled;
    45. 

  45. +  if (display_private_) {
    46. 

  46. +    // Invisible display is throttling itself.
    47. 

  47. +    display_private_->SetDisplayVisible(
    48. 

  48. +        background_throttling_ ? host_->IsVisible() : true);
    49. 

  49. +  }
    50. 

  50. +}
    51. 

  51. +
    52. 

  52.  #if BUILDFLAG(IS_CHROMEOS_ASH)
    53. 

  53.  void Compositor::SetSeamlessRefreshRates(
    54. 

  54.      const std::vector<float>& seamless_refresh_rates) {
    55. 

  55. diff --git a/ui/compositor/compositor.h b/ui/compositor/compositor.h
    56. 

  56. index 916a33ebd06e6750cef57ff433b1826424482d26..06a9e039beeb9ac6880a06bf15ec5e8bbbdb76f5 100644
    57. 

  57. --- a/ui/compositor/compositor.h
    58. 

  58. +++ b/ui/compositor/compositor.h
    59. 

  59. @@ -510,6 +510,10 @@ class COMPOSITOR_EXPORT Compositor : public base::PowerSuspendObserver,
    60. 

  60.  
    61. 

  61.    const cc::LayerTreeSettings& GetLayerTreeSettings() const;
    62. 

  62.  
    63. 

  63. +  // Sets |background_throttling_| responsible for suspending drawing
    64. 

  64. +  // and switching frames.
    65. 

  65. +  void SetBackgroundThrottling(bool background_throttling_enabled);
    66. 

  66. +
    67. 

  67.    size_t saved_events_metrics_count_for_testing() const {
    68. 

  68.      return host_->saved_events_metrics_count_for_testing();
    69. 

  69.    }
    70. 

  70. @@ -658,6 +662,12 @@ class COMPOSITOR_EXPORT Compositor : public base::PowerSuspendObserver,
    71. 

  71.    // See go/report-ux-metrics-at-painting for details.
    72. 

  72.    bool animation_started_ = false;
    73. 

  73.  
    74. 

  74. +  // Background throttling is a default Chromium behaviour. It occurs
    75. 

  75. +  // when the |display_private_| is not visible by prevent drawing and swapping
    76. 

  76. +  // frames. When it is disabled we are keeping |display_private_| always
    77. 

  77. +  // visible in order to keep generating frames.
    78. 

  78. +  bool background_throttling_ = true;
    79. 

  79. +
    80. 

  80.    TrackerId next_throughput_tracker_id_ = 1u;
    81. 

  81.    struct TrackerState {
    82. 

  82.      TrackerState();
    83.