fix_override_createjob_in_node_platform.patch 1.9 KB

123456789101112131415161718192021222324252627282930313233343536373839
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Keeley Hammond <[email protected]>
  3. Date: Tue, 2 Aug 2022 12:52:02 -0700
  4. Subject: fix: override createjob in node_platform
  5. Refs https://github.com/nodejs/node/pull/44741/commits/507dd20ef957acf261ec521fcbd81d745b17983c
  6. V8Platform::CreateJob was changed to an abstract method in https://chromium-review.googlesource.com/c/v8/v8/+/3779694,
  7. and is called by V8Platform::PostJob, so we should only call
  8. CreateJob in order to most closely match V8Platform default behavior.
  9. This patch can be removed when Electron updates to Node.js v20.
  10. diff --git a/src/node_platform.cc b/src/node_platform.cc
  11. index 7dd0526e6ece5fd86ab3847be592e778e48b5d37..a20622adb2ee8a2e3b05b336e481193624d5b810 100644
  12. --- a/src/node_platform.cc
  13. +++ b/src/node_platform.cc
  14. @@ -528,7 +528,7 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {
  15. return per_isolate->FlushForegroundTasksInternal();
  16. }
  17. -std::unique_ptr<v8::JobHandle> NodePlatform::PostJob(v8::TaskPriority priority,
  18. +std::unique_ptr<v8::JobHandle> NodePlatform::CreateJob(v8::TaskPriority priority,
  19. std::unique_ptr<v8::JobTask> job_task) {
  20. return v8::platform::NewDefaultJobHandle(
  21. this, priority, std::move(job_task), NumberOfWorkerThreads());
  22. diff --git a/src/node_platform.h b/src/node_platform.h
  23. index 4a05f3bba58c8e875d0ab67f292589edbb3b812b..1062f3b1b9c386a7bde8dca366c6f008bb183ab7 100644
  24. --- a/src/node_platform.h
  25. +++ b/src/node_platform.h
  26. @@ -155,7 +155,7 @@ class NodePlatform : public MultiIsolatePlatform {
  27. double CurrentClockTimeMillis() override;
  28. v8::TracingController* GetTracingController() override;
  29. bool FlushForegroundTasks(v8::Isolate* isolate) override;
  30. - std::unique_ptr<v8::JobHandle> PostJob(
  31. + std::unique_ptr<v8::JobHandle> CreateJob(
  32. v8::TaskPriority priority,
  33. std::unique_ptr<v8::JobTask> job_task) override;