Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: 2e4e6f10de
Branches Tags
electron
/
patches
/
chromium
/
support_mixed_sandbox_with_zygote.patch

support_mixed_sandbox_with_zygote.patch 4.4 KB
History Raw

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Jeremy Apthorp <[email protected]>
    3. 

  3. Date: Wed, 28 Nov 2018 13:20:27 -0800
    4. 

  4. Subject: support_mixed_sandbox_with_zygote.patch
    5. 

  5. 

  6. On Linux, Chromium launches all new renderer processes via a "zygote"
    7. 

  7. process which has the sandbox pre-initialized (see
    8. 

  8. //docs/linux_zygote.md). In order to support mixed-sandbox mode, in
    9. 

  9. which some renderers are launched with the sandbox engaged and others
    10. 

  10. without it, we need the option to launch non-sandboxed renderers without
    11. 

  11. going through the zygote.
    12. 

  12. 

  13. Chromium already supports a `--no-zygote` flag, but it turns off the
    14. 

  14. zygote completely, and thus also disables sandboxing. This patch allows
    15. 

  15. the `--no-zygote` flag to affect renderer processes on a case-by-case
    16. 

  16. basis, checking immediately prior to launch whether to go through the
    17. 

  17. zygote or not based on the command-line of the to-be-launched renderer.
    18. 

  18. 

  19. This patch could conceivably be upstreamed, as it does not affect
    20. 

  20. production Chromium (which does not use the `--no-zygote` flag).
    21. 

  21. However, the patch would need to be reviewed by the security team, as it
    22. 

  22. does touch a security-sensitive class.
    23. 

  23. 

  24. diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
    25. 

  25. index 23c2f323ce9172d6e8a42d0cc031da5a0540ce35..73cad457ad37cfdb5459c11e7828a543dc0cf31d 100644
    26. 

  26. --- a/content/browser/renderer_host/render_process_host_impl.cc
    27. 

  27. +++ b/content/browser/renderer_host/render_process_host_impl.cc
    28. 

  28. @@ -1723,9 +1723,15 @@ bool RenderProcessHostImpl::Init() {
    29. 

  29.      std::unique_ptr<SandboxedProcessLauncherDelegate> sandbox_delegate =
    30. 

  30.          std::make_unique<RendererSandboxedProcessLauncherDelegateWin>(
    31. 

  31.              *cmd_line, IsPdf(), IsJitDisabled());
    32. 

  32. +#else
    33. 

  33. +#if BUILDFLAG(USE_ZYGOTE)
    34. 

  34. +    bool use_zygote = !cmd_line->HasSwitch(switches::kNoZygote);
    35. 

  35. +    std::unique_ptr<SandboxedProcessLauncherDelegate> sandbox_delegate =
    36. 

  36. +        std::make_unique<RendererSandboxedProcessLauncherDelegate>(use_zygote);
    37. 

  37.  #else
    38. 

  38.      std::unique_ptr<SandboxedProcessLauncherDelegate> sandbox_delegate =
    39. 

  39.          std::make_unique<RendererSandboxedProcessLauncherDelegate>();
    40. 

  40. +#endif
    41. 

  41.  #endif
    42. 

  42.  
    43. 

  43.      auto file_data = std::make_unique<ChildProcessLauncherFileData>();
    44. 

  44. diff --git a/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.cc b/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.cc
    45. 

  45. index e5a087e3e26253901a84d509d8a4f1268a2569fe..7dab0443f8897553830f1f4cc98457839b354264 100644
    46. 

  46. --- a/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.cc
    47. 

  47. +++ b/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.cc
    48. 

  48. @@ -33,6 +33,9 @@ namespace content {
    49. 

  49.  
    50. 

  50.  #if BUILDFLAG(USE_ZYGOTE)
    51. 

  51.  ZygoteCommunication* RendererSandboxedProcessLauncherDelegate::GetZygote() {
    52. 

  52. +  if (!use_zygote_) {
    53. 

  53. +    return nullptr;
    54. 

  54. +  }
    55. 

  55.    const base::CommandLine& browser_command_line =
    56. 

  56.        *base::CommandLine::ForCurrentProcess();
    57. 

  57.    base::CommandLine::StringType renderer_prefix =
    58. 

  58. @@ -67,6 +70,9 @@ RendererSandboxedProcessLauncherDelegateWin::
    59. 

  59.        is_pdf_renderer_(is_pdf_renderer) {
    60. 

  60.    // PDF renderers must be jitless.
    61. 

  61.    CHECK(!is_pdf_renderer || is_jit_disabled);
    62. 

  62. +#if BUILDFLAG(USE_ZYGOTE)
    63. 

  63. +  use_zygote_ = !cmd_line->HasSwitch(switches::kNoZygote);
    64. 

  64. +#endif
    65. 

  65.    if (is_jit_disabled) {
    66. 

  66.      dynamic_code_can_be_disabled_ = true;
    67. 

  67.      return;
    68. 

  68. diff --git a/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.h b/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.h
    69. 

  69. index 00038da2c15696b361aea1469ccf73307e44963e..7ccfbf11ecfd56fd165915baa85919eaf2e923b9 100644
    70. 

  70. --- a/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.h
    71. 

  71. +++ b/content/browser/renderer_host/renderer_sandboxed_process_launcher_delegate.h
    72. 

  72. @@ -18,6 +18,11 @@ class CONTENT_EXPORT RendererSandboxedProcessLauncherDelegate
    73. 

  73.   public:
    74. 

  74.    RendererSandboxedProcessLauncherDelegate() = default;
    75. 

  75.  
    76. 

  76. +#if BUILDFLAG(USE_ZYGOTE)
    77. 

  77. +  RendererSandboxedProcessLauncherDelegate(bool use_zygote):
    78. 

  78. +    use_zygote_(use_zygote) {}
    79. 

  79. +#endif
    80. 

  80. +
    81. 

  81.    ~RendererSandboxedProcessLauncherDelegate() override = default;
    82. 

  82.  
    83. 

  83.  #if BUILDFLAG(USE_ZYGOTE)
    84. 

  84. @@ -30,6 +35,11 @@ class CONTENT_EXPORT RendererSandboxedProcessLauncherDelegate
    85. 

  85.  
    86. 

  86.    // sandbox::policy::SandboxDelegate:
    87. 

  87.    sandbox::mojom::Sandbox GetSandboxType() override;
    88. 

  88. +
    89. 

  89. + private:
    90. 

  90. +#if BUILDFLAG(USE_ZYGOTE)
    91. 

  91. +  bool use_zygote_ = true;
    92. 

  92. +#endif
    93. 

  93.  };
    94. 

  94.  
    95. 

  95.  #if BUILDFLAG(IS_WIN)
    96.