Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Tree: 2e4e6f10de
Branches Tags
electron
/
patches
/
chromium
/
fix_on-screen-keyboard_hides_on_input_blur_in_webview.patch

fix_on-screen-keyboard_hides_on_input_blur_in_webview.patch 3.1 KB
History Raw

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859 
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
    2. 

  2. From: Kyrylo Hrechykhin <[email protected]>
    3. 

  3. Date: Thu, 6 Oct 2022 18:30:53 +0200
    4. 

  4. Subject: fix: on-screen-keyboard hides on input blur in webview
    5. 

  5. 

  6. Changes introduced by this patch fix issue where OSK does not hide on
    7. 

  7. input rendered inside webview is blurred. This patch should be removed
    8. 

  8. when proper fix in chromium repo is available.
    9. 

  9. 

  10. Note: the issue still occurs if input rendered in webview blurred due
    11. 

  11. to touch outside of webview. It is caused by webview implementation
    12. 

  12. details. Specificaly due to webview has its own tree nodes and focused
    13. 

  13. node does not change in this case.
    14. 

  14. 

  15. chromium-bug: https://crbug.com/1369605
    16. 

  16. 

  17. diff --git a/content/browser/renderer_host/render_widget_host_view_child_frame.cc b/content/browser/renderer_host/render_widget_host_view_child_frame.cc
    18. 

  18. index c4312c899d5293eeb59d679dfa81a8f005f30940..906b47e935bdc3d37cf8313e5938bf79da335517 100644
    19. 

  19. --- a/content/browser/renderer_host/render_widget_host_view_child_frame.cc
    20. 

  20. +++ b/content/browser/renderer_host/render_widget_host_view_child_frame.cc
    21. 

  21. @@ -1039,6 +1039,12 @@ RenderWidgetHostViewChildFrame::DidUpdateVisualProperties(
    22. 

  22.    return viz::ScopedSurfaceIdAllocator(std::move(allocation_task));
    23. 

  23.  }
    24. 

  24.  
    25. 

  25. +void RenderWidgetHostViewChildFrame::FocusedNodeChanged(
    26. 

  26. +    bool is_editable_node,
    27. 

  27. +    const gfx::Rect& node_bounds_in_screen) {
    28. 

  28. +  NOTREACHED();
    29. 

  29. +}
    30. 

  30. +
    31. 

  31.  ui::TextInputType RenderWidgetHostViewChildFrame::GetTextInputType() const {
    32. 

  32.    if (!text_input_manager_)
    33. 

  33.      return ui::TEXT_INPUT_TYPE_NONE;
    34. 

  34. diff --git a/content/browser/renderer_host/render_widget_host_view_child_frame.h b/content/browser/renderer_host/render_widget_host_view_child_frame.h
    35. 

  35. index e340087e3ab2f07937ed6e6bd8e0ec8aa2a76d48..2b29e246b2f6ecf5d7605abfa36028642a7850c0 100644
    36. 

  36. --- a/content/browser/renderer_host/render_widget_host_view_child_frame.h
    37. 

  37. +++ b/content/browser/renderer_host/render_widget_host_view_child_frame.h
    38. 

  38. @@ -181,6 +181,8 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
    39. 

  39.    void DisableAutoResize(const gfx::Size& new_size) override;
    40. 

  40.    viz::ScopedSurfaceIdAllocator DidUpdateVisualProperties(
    41. 

  41.        const cc::RenderFrameMetadata& metadata) override;
    42. 

  42. +  void FocusedNodeChanged(bool is_editable_node,
    43. 

  43. +      const gfx::Rect& node_bounds_in_screen) override;
    44. 

  44.  
    45. 

  45.    // RenderFrameMetadataProvider::Observer implementation.
    46. 

  46.    void OnRenderFrameMetadataChangedBeforeActivation(
    47. 

  47. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
    48. 

  48. index a2e8526344318df726ea3af130aab3f72a3125e1..35b1cdcd9099bac3fd926ab6c9587dc5597c0d7d 100644
    49. 

  49. --- a/content/browser/web_contents/web_contents_impl.cc
    50. 

  50. +++ b/content/browser/web_contents/web_contents_impl.cc
    51. 

  51. @@ -8645,7 +8645,7 @@ void WebContentsImpl::OnFocusedElementChangedInFrame(
    52. 

  52.                          "WebContentsImpl::OnFocusedElementChangedInFrame",
    53. 

  53.                          "render_frame_host", frame);
    54. 

  54.    RenderWidgetHostViewBase* root_view =
    55. 

  55. -      static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
    56. 

  56. +      static_cast<RenderWidgetHostViewBase*>(GetTopLevelRenderWidgetHostView());
    57. 

  57.    if (!root_view || !frame->GetView()) {
    58. 

  58.      return;
    59. 

  59.    }
    60.