mas-cfisobjc.patch 1.6 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Thu, 20 Sep 2018 17:49:20 -0700
  4. Subject: mas: avoid usage of _CFIsObjC
  5. Removes usage of the _CFIsObjC private API.
  6. diff --git a/base/mac/foundation_util.mm b/base/mac/foundation_util.mm
  7. index 11fa4bb6714518b98321d5e10919de3e01403efd..c9232593c08be04cb62fe7163a240cbed4f6e464 100644
  8. --- a/base/mac/foundation_util.mm
  9. +++ b/base/mac/foundation_util.mm
  10. @@ -31,12 +31,6 @@
  11. #if !BUILDFLAG(IS_IOS)
  12. CFTypeID SecACLGetTypeID();
  13. CFTypeID SecTrustedApplicationGetTypeID();
  14. -// The NSFont/CTFont toll-free bridging is broken before 10.15.
  15. -// http://www.openradar.me/15341349 rdar://15341349
  16. -//
  17. -// TODO(https://crbug.com/1076527): This is fixed in 10.15. When 10.15 is the
  18. -// minimum OS for Chromium, remove this SPI declaration.
  19. -Boolean _CFIsObjC(CFTypeID typeID, CFTypeRef obj);
  20. #endif
  21. } // extern "C"
  22. @@ -328,8 +322,7 @@ void SetBaseBundleID(const char* new_base_bundle_id) {
  23. const_cast<NSFont*>(reinterpret_cast<const NSFont*>(cf_val));
  24. DCHECK(!cf_val ||
  25. CTFontGetTypeID() == CFGetTypeID(cf_val) ||
  26. - (_CFIsObjC(CTFontGetTypeID(), cf_val) &&
  27. - [ns_val isKindOfClass:[NSFont class]]));
  28. + ([ns_val isKindOfClass:[NSFont class]]));
  29. return ns_val;
  30. }
  31. @@ -400,9 +393,6 @@ CTFontRef NSToCFCast(NSFont* ns_val) {
  32. return (CTFontRef)(cf_val);
  33. }
  34. - if (!_CFIsObjC(CTFontGetTypeID(), cf_val))
  35. - return NULL;
  36. -
  37. id<NSObject> ns_val = reinterpret_cast<id>(const_cast<void*>(cf_val));
  38. if ([ns_val isKindOfClass:[NSFont class]]) {
  39. return (CTFontRef)(cf_val);