fix_use_electron_generated_resources.patch 2.4 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Thu, 24 Sep 2020 11:10:41 -0700
  4. Subject: fix: use electron generated resources
  5. This patch fixes a few instances where we need to use Electron generated
  6. resources for IDS strings, or the IDs will be wrong and cause DCHECKS
  7. as they will loaded as empty strings.
  8. * IDS_UTILITY_PROCESS_UTILITY_WIN_NAME on Windows
  9. * IDR_PDF_MANIFEST on Linux
  10. * IDS_UTILITY_PROCESS_PRINTING_SERVICE_NAME on Windows
  11. diff --git a/chrome/browser/pdf/pdf_extension_util.cc b/chrome/browser/pdf/pdf_extension_util.cc
  12. index f72431f5bc7ba82316cf318f7845e7523c366d92..5133f3cd28c0d630a039118eb91c6c37ee202f3e 100644
  13. --- a/chrome/browser/pdf/pdf_extension_util.cc
  14. +++ b/chrome/browser/pdf/pdf_extension_util.cc
  15. @@ -11,8 +11,7 @@
  16. #include "build/chromeos_buildflags.h"
  17. #include "chrome/browser/browser_process.h"
  18. #include "chrome/common/chrome_content_client.h"
  19. -#include "chrome/grit/browser_resources.h"
  20. -#include "chrome/grit/generated_resources.h"
  21. +#include "electron/grit/electron_resources.h"
  22. #include "components/strings/grit/components_strings.h"
  23. #include "components/zoom/page_zoom_constants.h"
  24. #include "pdf/pdf_features.h"
  25. diff --git a/chrome/browser/printing/printing_service.cc b/chrome/browser/printing/printing_service.cc
  26. index 6d18517898c11c6a628cec2eade57fe845827b3d..a21f52e8a3c6f80d69b27faae4b77700fdd09e35 100644
  27. --- a/chrome/browser/printing/printing_service.cc
  28. +++ b/chrome/browser/printing/printing_service.cc
  29. @@ -5,7 +5,7 @@
  30. #include "chrome/browser/printing/printing_service.h"
  31. #include "base/no_destructor.h"
  32. -#include "chrome/grit/generated_resources.h"
  33. +#include "electron/grit/electron_resources.h"
  34. #include "chrome/services/printing/public/mojom/printing_service.mojom.h"
  35. #include "content/public/browser/service_process_host.h"
  36. diff --git a/chrome/browser/win/icon_reader_service.cc b/chrome/browser/win/icon_reader_service.cc
  37. index d5497a7e26cdb66c7c074bc509e2bfec7d7875cd..62d2f555253eef903bd04ff1a0ad37d1470309e0 100644
  38. --- a/chrome/browser/win/icon_reader_service.cc
  39. +++ b/chrome/browser/win/icon_reader_service.cc
  40. @@ -4,7 +4,7 @@
  41. #include "chrome/browser/win/icon_reader_service.h"
  42. -#include "chrome/grit/generated_resources.h"
  43. +#include "electron/grit/electron_resources.h"
  44. #include "chrome/services/util_win/public/mojom/util_read_icon.mojom.h"
  45. #include "content/public/browser/service_process_host.h"