chore_expose_v8_initialization_isolate_callbacks.patch 2.2 KB

1234567891011121314151617181920212223242526272829303132333435363738394041
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Mon, 5 Oct 2020 13:43:59 -0700
  4. Subject: chore: expose v8 initialization isolate callbacks
  5. This commit is necessary in order to ensure consistent behavior from
  6. v8 Isolate callbacks in contexts which Node.js does not control. If
  7. we're running with contextIsolation enabled, we should be falling back
  8. to Blink's logic. This will be upstreamed in some form.
  9. diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
  10. index feae0aea593ef1945c1063b7d487892530f7ceed..beb0a9e85a0f5e102466952c220aafac2d6ebb39 100644
  11. --- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
  12. +++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
  13. @@ -457,8 +457,9 @@ CodeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context,
  14. return {true, std::move(stringified_source)};
  15. }
  16. -bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context,
  17. - v8::Local<v8::String> source) {
  18. +bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread(
  19. + v8::Local<v8::Context> context,
  20. + v8::Local<v8::String> source) {
  21. if (ExecutionContext* execution_context = ToExecutionContext(context)) {
  22. if (ContentSecurityPolicy* policy =
  23. execution_context->GetContentSecurityPolicy()) {
  24. diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
  25. index 932c6aad3df51dd6790e55bf708703767843dc5e..6865fd33e62f766c5a162ded8627c332bf2ed173 100644
  26. --- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
  27. +++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h
  28. @@ -69,8 +69,8 @@ class CORE_EXPORT V8Initializer {
  29. static void MessageHandlerInWorker(v8::Local<v8::Message>,
  30. v8::Local<v8::Value>);
  31. static bool WasmCodeGenerationCheckCallbackInMainThread(
  32. - v8::Local<v8::Context> context,
  33. - v8::Local<v8::String> source);
  34. + v8::Local<v8::Context> context,
  35. + v8::Local<v8::String> source);
  36. };
  37. } // namespace blink