fix_use_electron_generated_resources.patch 2.4 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Thu, 24 Sep 2020 11:10:41 -0700
  4. Subject: fix: use electron generated resources
  5. This patch fixes a few instances where we need to use Electron generated
  6. resources for IDS strings, or the IDs will be wrong and cause DCHECKS
  7. as they will loaded as empty strings.
  8. * IDS_UTILITY_PROCESS_UTILITY_WIN_NAME on Windows
  9. * IDR_PDF_MANIFEST on Linux
  10. * IDS_UTILITY_PROCESS_PRINTING_SERVICE_NAME on Windows
  11. diff --git a/chrome/browser/pdf/pdf_extension_util.cc b/chrome/browser/pdf/pdf_extension_util.cc
  12. index f4dd5157210dafc93b40055f1179c730c9809ff3..f9fa3a8146b41f81fe8ec7c6e60f5c257e953387 100644
  13. --- a/chrome/browser/pdf/pdf_extension_util.cc
  14. +++ b/chrome/browser/pdf/pdf_extension_util.cc
  15. @@ -9,8 +9,7 @@
  16. #include "build/chromeos_buildflags.h"
  17. #include "chrome/browser/browser_process.h"
  18. #include "chrome/common/chrome_content_client.h"
  19. -#include "chrome/grit/browser_resources.h"
  20. -#include "chrome/grit/generated_resources.h"
  21. +#include "electron/grit/electron_resources.h"
  22. #include "components/strings/grit/components_strings.h"
  23. #include "components/zoom/page_zoom_constants.h"
  24. #include "pdf/pdf_features.h"
  25. diff --git a/chrome/browser/printing/printing_service.cc b/chrome/browser/printing/printing_service.cc
  26. index 2b73b110049b5e8d28b52656bbd2423e18ba07a0..8fd868b39d64c74aa189b8ca3e24c8537d91b1ba 100644
  27. --- a/chrome/browser/printing/printing_service.cc
  28. +++ b/chrome/browser/printing/printing_service.cc
  29. @@ -6,7 +6,7 @@
  30. #include "base/no_destructor.h"
  31. #include "chrome/browser/service_sandbox_type.h"
  32. -#include "chrome/grit/generated_resources.h"
  33. +#include "electron/grit/electron_resources.h"
  34. #include "content/public/browser/service_process_host.h"
  35. const mojo::Remote<printing::mojom::PrintingService>& GetPrintingService() {
  36. diff --git a/chrome/browser/win/icon_reader_service.cc b/chrome/browser/win/icon_reader_service.cc
  37. index 721e1a863cc6925908f8343002df056f2373bf0b..10b2a95162541a8ff4d010c7be864f3f41dae378 100644
  38. --- a/chrome/browser/win/icon_reader_service.cc
  39. +++ b/chrome/browser/win/icon_reader_service.cc
  40. @@ -5,7 +5,7 @@
  41. #include "chrome/browser/win/icon_reader_service.h"
  42. #include "chrome/browser/service_sandbox_type.h"
  43. -#include "chrome/grit/generated_resources.h"
  44. +#include "electron/grit/electron_resources.h"
  45. #include "content/public/browser/service_process_host.h"
  46. mojo::Remote<chrome::mojom::UtilReadIcon> LaunchIconReaderInstance() {