123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Jeremy Apthorp <[email protected]>
- Date: Wed, 28 Aug 2019 12:21:25 -0700
- Subject: expose SetUserAgent on NetworkContext
- Applying
- https://chromium-review.googlesource.com/c/chromium/src/+/1585083 before
- it's merged. There may end up being a better way of doing this, or the
- patch may be merged upstream, at which point this patch should be
- removed.
- diff --git a/net/url_request/static_http_user_agent_settings.h b/net/url_request/static_http_user_agent_settings.h
- index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a289703d8b0577 100644
- --- a/net/url_request/static_http_user_agent_settings.h
- +++ b/net/url_request/static_http_user_agent_settings.h
- @@ -26,13 +26,17 @@ class NET_EXPORT StaticHttpUserAgentSettings : public HttpUserAgentSettings {
- accept_language_ = new_accept_language;
- }
-
- + void set_user_agent(const std::string& new_user_agent) {
- + user_agent_ = new_user_agent;
- + }
- +
- // HttpUserAgentSettings implementation
- std::string GetAcceptLanguage() const override;
- std::string GetUserAgent() const override;
-
- private:
- std::string accept_language_;
- - const std::string user_agent_;
- + std::string user_agent_;
-
- DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings);
- };
- diff --git a/services/network/network_context.cc b/services/network/network_context.cc
- index a07176cf0fd3c7160922e7f9919e775cb3b6fe71..5d59a8cc4fec91de95ddbb90dab1df9334081fac 100644
- --- a/services/network/network_context.cc
- +++ b/services/network/network_context.cc
- @@ -1036,6 +1036,13 @@ void NetworkContext::SetNetworkConditions(
- std::move(network_conditions));
- }
-
- +void NetworkContext::SetUserAgent(const std::string& new_user_agent) {
- + // This may only be called on NetworkContexts created with a constructor that
- + // calls ApplyContextParamsToBuilder.
- + DCHECK(user_agent_settings_);
- + user_agent_settings_->set_user_agent(new_user_agent);
- +}
- +
- void NetworkContext::SetAcceptLanguage(const std::string& new_accept_language) {
- // This may only be called on NetworkContexts created with the constructor
- // that calls MakeURLRequestContext().
- diff --git a/services/network/network_context.h b/services/network/network_context.h
- index dd65d1560daa8fde7d76e0dec8e1cdcb6c76b318..042f62dafcb027f0a65318d09dfadf751c792329 100644
- --- a/services/network/network_context.h
- +++ b/services/network/network_context.h
- @@ -243,6 +243,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext
- void CloseIdleConnections(CloseIdleConnectionsCallback callback) override;
- void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
- mojom::NetworkConditionsPtr conditions) override;
- + void SetUserAgent(const std::string& new_user_agent) override;
- void SetAcceptLanguage(const std::string& new_accept_language) override;
- void SetEnableReferrers(bool enable_referrers) override;
- #if defined(OS_CHROMEOS)
- diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom
- index 577c2b431ae8026b34fa1d881b0b29db478dc213..6d15b6b5ff7b36b85f6b8200b76a32b285f0e675 100644
- --- a/services/network/public/mojom/network_context.mojom
- +++ b/services/network/public/mojom/network_context.mojom
- @@ -1050,6 +1050,9 @@ interface NetworkContext {
- SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id,
- NetworkConditions? conditions);
-
- + // Updates the user agent to be used for requests.
- + SetUserAgent(string new_user_agent);
- +
- // Updates the Accept-Language header to be used for requests.
- SetAcceptLanguage(string new_accept_language);
-
- diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h
- index ef97b4cef0aa4d67926cf42c8ae20e9b90e73531..65831a37e753a9255507a905f80f727f4214441e 100644
- --- a/services/network/test/test_network_context.h
- +++ b/services/network/test/test_network_context.h
- @@ -105,6 +105,7 @@ class TestNetworkContext : public mojom::NetworkContext {
- void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {}
- void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id,
- mojom::NetworkConditionsPtr conditions) override {}
- + void SetUserAgent(const std::string& new_user_agent) override {}
- void SetAcceptLanguage(const std::string& new_accept_language) override {}
- void SetEnableReferrers(bool enable_referrers) override {}
- #if defined(OS_CHROMEOS)
|