build_gn.patch 1.2 KB

1234567891011121314151617181920212223242526272829303132333435363738394041
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Jeremy Apthorp <[email protected]>
  3. Date: Tue, 16 Apr 2019 10:43:04 -0700
  4. Subject: build_gn.patch
  5. We force V8 into 'shared library' mode so that it exports its symbols, which is
  6. necessary for native modules to load.
  7. Also, some fixes relating to mksnapshot on ARM.
  8. diff --git a/BUILD.gn b/BUILD.gn
  9. index 94b598bc9a2882c1a47fad6d2c47068b472ecb6c..128271ee0305baef31001894a163beff98bcdd6a 100644
  10. --- a/BUILD.gn
  11. +++ b/BUILD.gn
  12. @@ -410,7 +410,7 @@ config("internal_config") {
  13. ":v8_header_features",
  14. ]
  15. - if (is_component_build) {
  16. + if (is_component_build || is_electron_build) {
  17. defines += [ "BUILDING_V8_SHARED" ]
  18. }
  19. }
  20. @@ -4477,7 +4477,7 @@ if (current_toolchain == v8_generator_toolchain) {
  21. "src/interpreter/bytecodes.h",
  22. ]
  23. - configs = [ ":internal_config" ]
  24. + configs = [ ":internal_config_base" ]
  25. deps = [
  26. ":v8_libbase",
  27. @@ -4514,6 +4514,8 @@ if (current_toolchain == v8_snapshot_toolchain) {
  28. configs = [ ":internal_config" ]
  29. + configs += [ "//electron/build/config:build_time_executable" ]
  30. +
  31. deps = [
  32. ":v8_base_without_compiler",
  33. ":v8_compiler_for_mksnapshot",