123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680 |
- From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
- From: Shelley Vohr <[email protected]>
- Date: Fri, 7 Jun 2019 13:59:37 -0700
- Subject: printing.patch
- Add changeset that was previously applied to sources in chromium_src. The
- majority of changes originally come from these PRs:
- * https://github.com/electron/electron/pull/1835
- * https://github.com/electron/electron/pull/8596
- This patch also fixes callback for manual user cancellation and success.
- diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc
- index 668a14bff461e83b2c6d9d7f23d9674ff081ef12..77912096bb99cfa0d3b081d6ad9bdfec4d32569a 100644
- --- a/chrome/browser/printing/print_job.cc
- +++ b/chrome/browser/printing/print_job.cc
- @@ -347,18 +347,25 @@ void PrintJob::StartPdfToEmfConversion(
- // seems to work with the fix for this bug applied.
- const PrintSettings& settings = document()->settings();
- bool print_text_with_gdi =
- - settings.print_text_with_gdi() && !settings.printer_is_xps() &&
- +#if defined(OS_WIN)
- + settings.is_modifiable()
- +#else
- + settings.print_text_with_gdi()
- +#endif
- + && !settings.printer_is_xps() &&
- base::FeatureList::IsEnabled(::features::kGdiTextPrinting);
-
- // TODO(thestig): Figure out why crbug.com/1083911 occurred, which is likely
- // because |web_contents| was null. As a result, this section has many more
- // pointer checks to avoid crashing.
- +#if 0
- content::WebContents* web_contents = worker_->GetWebContents();
- content::BrowserContext* context =
- web_contents ? web_contents->GetBrowserContext() : nullptr;
- PrefService* prefs =
- context ? Profile::FromBrowserContext(context)->GetPrefs() : nullptr;
- - bool print_with_reduced_rasterization = PrintWithReducedRasterization(prefs);
- +#endif
- + bool print_with_reduced_rasterization = PrintWithReducedRasterization(nullptr);
-
- using RenderMode = PdfRenderSettings::Mode;
- RenderMode mode;
- diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc
- index 52efa2037a31f84a261502107bfebc69ae5a419e..4834e92ae99f12043e5ce476370f64345ad29001 100644
- --- a/chrome/browser/printing/print_job_worker.cc
- +++ b/chrome/browser/printing/print_job_worker.cc
- @@ -20,7 +20,6 @@
- #include "chrome/browser/browser_process.h"
- #include "chrome/browser/chrome_notification_types.h"
- #include "chrome/browser/printing/print_job.h"
- -#include "chrome/grit/generated_resources.h"
- #include "components/crash/core/common/crash_keys.h"
- #include "content/public/browser/browser_task_traits.h"
- #include "content/public/browser/browser_thread.h"
- @@ -28,6 +27,7 @@
- #include "content/public/browser/render_frame_host.h"
- #include "content/public/browser/web_contents.h"
- #include "printing/backend/print_backend.h"
- +#include "electron/grit/electron_resources.h"
- #include "printing/print_job_constants.h"
- #include "printing/printed_document.h"
- #include "printing/printing_utils.h"
- @@ -235,16 +235,21 @@ void PrintJobWorker::UpdatePrintSettings(base::Value new_settings,
- #endif // defined(OS_LINUX) && defined(USE_CUPS) && !defined(OS_CHROMEOS)
- }
-
- - PrintingContext::Result result;
- {
- #if defined(OS_WIN)
- // Blocking is needed here because Windows printer drivers are oftentimes
- // not thread-safe and have to be accessed on the UI thread.
- base::ScopedAllowBlocking allow_blocking;
- #endif
- - result = printing_context_->UpdatePrintSettings(std::move(new_settings));
- + // Reset settings from previous print job
- + printing_context_->ResetSettings();
- + PrintingContext::Result get_default_result = printing_context_->UseDefaultSettings();
- + if (get_default_result == PrintingContext::Result::OK) {
- + PrintingContext::Result update_result =
- + printing_context_->UpdatePrintSettings(std::move(new_settings));
- + GetSettingsDone(std::move(callback), update_result);
- + }
- }
- - GetSettingsDone(std::move(callback), result);
- }
-
- #if defined(OS_CHROMEOS)
- @@ -260,6 +265,13 @@ void PrintJobWorker::UpdatePrintSettingsFromPOD(
-
- void PrintJobWorker::GetSettingsDone(SettingsCallback callback,
- PrintingContext::Result result) {
- + if (result == PrintingContext::CANCEL) {
- + print_job_->PostTask(
- + FROM_HERE,
- + base::BindOnce(&NotificationCallback, base::RetainedRef(print_job_),
- + JobEventDetails::USER_INIT_CANCELED, 0,
- + base::RetainedRef(document_)));
- + }
- std::move(callback).Run(printing_context_->TakeAndResetSettings(), result);
- }
-
- diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc
- index 8a743d0dd74b087059ff812019ae568a22c5fa01..7224fa1556205c224db8326ca048f42939ac0580 100644
- --- a/chrome/browser/printing/print_view_manager_base.cc
- +++ b/chrome/browser/printing/print_view_manager_base.cc
- @@ -27,10 +27,7 @@
- #include "chrome/browser/printing/print_view_manager_common.h"
- #include "chrome/browser/printing/printer_query.h"
- #include "chrome/browser/profiles/profile.h"
- -#include "chrome/browser/ui/simple_message_box.h"
- -#include "chrome/browser/ui/webui/print_preview/printer_handler.h"
- #include "chrome/common/pref_names.h"
- -#include "chrome/grit/generated_resources.h"
- #include "chromeos/constants/chromeos_features.h"
- #include "components/prefs/pref_service.h"
- #include "components/printing/browser/print_composite_client.h"
- @@ -47,6 +44,7 @@
- #include "content/public/browser/render_process_host.h"
- #include "content/public/browser/render_view_host.h"
- #include "content/public/browser/web_contents.h"
- +#include "electron/grit/electron_resources.h"
- #include "mojo/public/cpp/system/buffer.h"
- #include "printing/buildflags/buildflags.h"
- #include "printing/metafile_skia.h"
- @@ -70,6 +68,8 @@ using PrintSettingsCallback =
- base::OnceCallback<void(std::unique_ptr<PrinterQuery>)>;
-
- void ShowWarningMessageBox(const base::string16& message) {
- + LOG(ERROR) << "Invalid printer settings " << message;
- +#if 0
- // Runs always on the UI thread.
- static bool is_dialog_shown = false;
- if (is_dialog_shown)
- @@ -78,6 +78,7 @@ void ShowWarningMessageBox(const base::string16& message) {
- base::AutoReset<bool> auto_reset(&is_dialog_shown, true);
-
- chrome::ShowWarningMessageBox(nullptr, base::string16(), message);
- +#endif
- }
-
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- @@ -116,12 +117,14 @@ PrintViewManagerBase::PrintViewManagerBase(content::WebContents* web_contents)
- printing_succeeded_(false),
- queue_(g_browser_process->print_job_manager()->queue()) {
- DCHECK(queue_);
- +#if 0
- Profile* profile =
- Profile::FromBrowserContext(web_contents->GetBrowserContext());
- printing_enabled_.Init(
- prefs::kPrintingEnabled, profile->GetPrefs(),
- base::BindRepeating(&PrintViewManagerBase::UpdatePrintingEnabled,
- weak_ptr_factory_.GetWeakPtr()));
- +#endif
- }
-
- PrintViewManagerBase::~PrintViewManagerBase() {
- @@ -129,7 +132,10 @@ PrintViewManagerBase::~PrintViewManagerBase() {
- DisconnectFromCurrentPrintJob();
- }
-
- -bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh) {
- +bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh,
- + bool silent,
- + base::Value settings,
- + CompletionCallback callback) {
- DisconnectFromCurrentPrintJob();
-
- // Don't print / print preview crashed tabs.
- @@ -137,7 +143,14 @@ bool PrintViewManagerBase::PrintNow(content::RenderFrameHost* rfh) {
- return false;
-
- SetPrintingRFH(rfh);
- - GetPrintRenderFrame(rfh)->PrintRequestedPages();
- + callback_ = std::move(callback);
- +
- + if (!callback_.is_null()) {
- + registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
- + content::NotificationService::AllSources());
- + }
- +
- + GetPrintRenderFrame(rfh)->PrintRequestedPages(silent, std::move(settings));
- return true;
- }
-
- @@ -258,9 +271,9 @@ void PrintViewManagerBase::StartLocalPrintJob(
- void PrintViewManagerBase::UpdatePrintingEnabled() {
- DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- // The Unretained() is safe because ForEachFrame() is synchronous.
- - web_contents()->ForEachFrame(base::BindRepeating(
- - &PrintViewManagerBase::SendPrintingEnabled, base::Unretained(this),
- - printing_enabled_.GetValue()));
- + web_contents()->ForEachFrame(
- + base::BindRepeating(&PrintViewManagerBase::SendPrintingEnabled,
- + base::Unretained(this), true));
- }
-
- void PrintViewManagerBase::NavigationStopped() {
- @@ -363,7 +376,7 @@ void PrintViewManagerBase::OnPrintingFailed(int cookie) {
- PrintManager::OnPrintingFailed(cookie);
-
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- - ShowPrintErrorDialog();
- + // ShowPrintErrorDialog();
- #endif
-
- ReleasePrinterQuery();
- @@ -382,6 +395,11 @@ void PrintViewManagerBase::OnScriptedPrint(
- }
-
- void PrintViewManagerBase::OnShowInvalidPrinterSettingsError() {
- + if (!callback_.is_null()) {
- + std::string cb_str = "Invalid printer settings";
- + std::move(callback_).Run(printing_succeeded_, cb_str);
- + }
- +
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::BindOnce(&ShowWarningMessageBox,
- l10n_util::GetStringUTF16(
- @@ -463,9 +481,13 @@ void PrintViewManagerBase::OnNotifyPrintJobEvent(
- content::NotificationService::NoDetails());
- break;
- }
- - case JobEventDetails::USER_INIT_DONE:
- - case JobEventDetails::DEFAULT_INIT_DONE:
- case JobEventDetails::USER_INIT_CANCELED: {
- + printing_cancelled_ = true;
- + ReleasePrintJob();
- + break;
- + }
- + case JobEventDetails::USER_INIT_DONE:
- + case JobEventDetails::DEFAULT_INIT_DONE: {
- NOTREACHED();
- break;
- }
- @@ -560,8 +582,10 @@ bool PrintViewManagerBase::CreateNewPrintJob(
- DCHECK(!quit_inner_loop_);
- DCHECK(query);
-
- - // Disconnect the current |print_job_|.
- - DisconnectFromCurrentPrintJob();
- + if (callback_.is_null()) {
- + // Disconnect the current |print_job_| only when calling window.print()
- + DisconnectFromCurrentPrintJob();
- + }
-
- // We can't print if there is no renderer.
- if (!web_contents()->GetRenderViewHost() ||
- @@ -582,8 +606,6 @@ bool PrintViewManagerBase::CreateNewPrintJob(
- print_job_->SetSource(source, /*source_id=*/"");
- #endif
-
- - registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
- - content::Source<PrintJob>(print_job_.get()));
- printing_succeeded_ = false;
- return true;
- }
- @@ -632,14 +654,21 @@ void PrintViewManagerBase::ReleasePrintJob() {
- content::RenderFrameHost* rfh = printing_rfh_;
- printing_rfh_ = nullptr;
-
- + if (!callback_.is_null()) {
- + registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
- + content::NotificationService::AllSources());
- + std::string cb_str = "";
- + if (!printing_succeeded_)
- + cb_str = printing_cancelled_ ? "cancelled" : "failed";
- + std::move(callback_).Run(printing_succeeded_, cb_str);
- + }
- +
- if (!print_job_)
- return;
-
- if (rfh)
- GetPrintRenderFrame(rfh)->PrintingDone(printing_succeeded_);
-
- - registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_EVENT,
- - content::Source<PrintJob>(print_job_.get()));
- // Don't close the worker thread.
- print_job_ = nullptr;
- }
- @@ -675,7 +704,7 @@ bool PrintViewManagerBase::RunInnerMessageLoop() {
- }
-
- bool PrintViewManagerBase::OpportunisticallyCreatePrintJob(int cookie) {
- - if (print_job_)
- + if (print_job_ && print_job_->document())
- return true;
-
- if (!cookie) {
- diff --git a/chrome/browser/printing/print_view_manager_base.h b/chrome/browser/printing/print_view_manager_base.h
- index 94b65e85561e1440b60086b668865bda07303d35..7044463d163fd74e55ff1a042c36739fdeff3689 100644
- --- a/chrome/browser/printing/print_view_manager_base.h
- +++ b/chrome/browser/printing/print_view_manager_base.h
- @@ -33,6 +33,8 @@ class PrintJob;
- class PrintQueriesQueue;
- class PrinterQuery;
-
- +using CompletionCallback = base::OnceCallback<void(bool, const std::string&)>;
- +
- // Base class for managing the print commands for a WebContents.
- class PrintViewManagerBase : public content::NotificationObserver,
- public PrintManager {
- @@ -42,7 +44,10 @@ class PrintViewManagerBase : public content::NotificationObserver,
- // Prints the current document immediately. Since the rendering is
- // asynchronous, the actual printing will not be completed on the return of
- // this function. Returns false if printing is impossible at the moment.
- - virtual bool PrintNow(content::RenderFrameHost* rfh);
- + virtual bool PrintNow(content::RenderFrameHost* rfh,
- + bool silent,
- + base::Value settings,
- + CompletionCallback callback);
-
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- // Prints the document in |print_data| with settings specified in
- @@ -205,9 +210,15 @@ class PrintViewManagerBase : public content::NotificationObserver,
- // The current RFH that is printing with a system printing dialog.
- content::RenderFrameHost* printing_rfh_;
-
- + // Respond with success of the print job.
- + CompletionCallback callback_;
- +
- // Indication of success of the print job.
- bool printing_succeeded_;
-
- + // Indication of whether the print job was manually cancelled
- + bool printing_cancelled_ = false;
- +
- // Set while running an inner message loop inside RenderAllMissingPagesNow().
- // This means we are _blocking_ until all the necessary pages have been
- // rendered or the print settings are being loaded.
- diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc
- index fb5d48349eee9469153d27084cf9ac9b08953b7a..cfd7c5162bba2771b6b5323ee179f640a9d92617 100644
- --- a/chrome/browser/printing/printing_message_filter.cc
- +++ b/chrome/browser/printing/printing_message_filter.cc
- @@ -21,6 +21,7 @@
- #include "components/keyed_service/content/browser_context_keyed_service_shutdown_notifier_factory.h"
- #include "components/printing/browser/print_manager_utils.h"
- #include "components/printing/common/print_messages.h"
- +#include "content/public/browser/browser_context.h"
- #include "content/public/browser/browser_task_traits.h"
- #include "content/public/browser/render_frame_host.h"
- #include "content/public/browser/web_contents.h"
- @@ -89,19 +90,22 @@ void PrintingMessageFilter::SetDelegateForTesting(TestDelegate* delegate) {
- g_test_delegate = delegate;
- }
-
- -PrintingMessageFilter::PrintingMessageFilter(int render_process_id,
- - Profile* profile)
- +PrintingMessageFilter::PrintingMessageFilter(
- + int render_process_id,
- + content::BrowserContext* browser_context)
- : BrowserMessageFilter(PrintMsgStart),
- render_process_id_(render_process_id),
- queue_(g_browser_process->print_job_manager()->queue()) {
- DCHECK(queue_.get());
- printing_shutdown_notifier_ =
- PrintingMessageFilterShutdownNotifierFactory::GetInstance()
- - ->Get(profile)
- + ->Get(browser_context)
- ->Subscribe(base::Bind(&PrintingMessageFilter::ShutdownOnUIThread,
- base::Unretained(this)));
- + #if 0
- is_printing_enabled_.Init(prefs::kPrintingEnabled, profile->GetPrefs());
- is_printing_enabled_.MoveToSequence(content::GetIOThreadTaskRunner({}));
- + #endif
- }
-
- PrintingMessageFilter::~PrintingMessageFilter() {
- @@ -136,11 +140,13 @@ bool PrintingMessageFilter::OnMessageReceived(const IPC::Message& message) {
-
- void PrintingMessageFilter::OnGetDefaultPrintSettings(IPC::Message* reply_msg) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
- +#if 0
- if (!is_printing_enabled_.GetValue()) {
- // Reply with null query.
- OnGetDefaultPrintSettingsReply(nullptr, reply_msg);
- return;
- }
- +#endif
- std::unique_ptr<PrinterQuery> printer_query = queue_->PopPrinterQuery(0);
- if (!printer_query) {
- printer_query =
- @@ -226,12 +232,13 @@ void PrintingMessageFilter::OnScriptedPrintReply(
- void PrintingMessageFilter::OnUpdatePrintSettings(int document_cookie,
- base::Value job_settings,
- IPC::Message* reply_msg) {
- +#if 0
- if (!is_printing_enabled_.GetValue()) {
- // Reply with null query.
- OnUpdatePrintSettingsReply(nullptr, reply_msg);
- return;
- }
- -
- +#endif
- if (!job_settings.is_dict() ||
- !job_settings.FindIntKey(kSettingPrinterType)) {
- // Reply with null query.
- @@ -264,7 +271,9 @@ void PrintingMessageFilter::OnUpdatePrintSettingsReply(
- std::unique_ptr<PrinterQuery> printer_query,
- IPC::Message* reply_msg) {
- PrintMsg_PrintPages_Params params;
- - if (!printer_query || printer_query->last_status() != PrintingContext::OK) {
- + // We call update without first printing from defaults,
- + // so the last printer status will still be defaulted to PrintingContext::FAILED
- + if (!printer_query) {
- params.Reset();
- } else {
- RenderParamsFromPrintSettings(printer_query->settings(), ¶ms.params);
- @@ -302,7 +311,7 @@ void PrintingMessageFilter::OnUpdatePrintSettingsReply(
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- void PrintingMessageFilter::OnCheckForCancel(const PrintHostMsg_PreviewIds& ids,
- bool* cancel) {
- - *cancel = PrintPreviewUI::ShouldCancelRequest(ids);
- + *cancel = false;
- }
- #endif
-
- diff --git a/chrome/browser/printing/printing_message_filter.h b/chrome/browser/printing/printing_message_filter.h
- index 9fbea6d0a2dbe55b1d600fbc217dee5aa8ae8cd5..de9bd267e408c02fd4da7d903523c0e6305088d5 100644
- --- a/chrome/browser/printing/printing_message_filter.h
- +++ b/chrome/browser/printing/printing_message_filter.h
- @@ -24,6 +24,10 @@ struct PrintHostMsg_ScriptedPrint_Params;
- struct PrintMsg_Print_Params;
- class Profile;
-
- +namespace content {
- +class BrowserContext;
- +}
- +
- namespace printing {
-
- class PrintQueriesQueue;
- @@ -44,7 +48,8 @@ class PrintingMessageFilter : public content::BrowserMessageFilter {
-
- static void SetDelegateForTesting(TestDelegate* delegate);
-
- - PrintingMessageFilter(int render_process_id, Profile* profile);
- + PrintingMessageFilter(int render_process_id,
- + content::BrowserContext* browser_context);
-
- // content::BrowserMessageFilter:
- bool OnMessageReceived(const IPC::Message& message) override;
- diff --git a/components/printing/common/print.mojom b/components/printing/common/print.mojom
- index faccd2a6881b74f1fa6538fc1011071ac54b03e0..342fba6eb86ee803aae6f11826ee5ccc1a6eeed0 100644
- --- a/components/printing/common/print.mojom
- +++ b/components/printing/common/print.mojom
- @@ -99,7 +99,7 @@ interface PrintPreviewUI {
- interface PrintRenderFrame {
- // Tells the RenderFrame to switch the CSS to print media type, render every
- // requested page, and then switch back the CSS to display media type.
- - PrintRequestedPages();
- + PrintRequestedPages(bool silent, mojo_base.mojom.DictionaryValue settings);
-
- // Tells the RenderFrame to switch the CSS to print media type, render every
- // requested page using the print preview document's frame/node, and then
- diff --git a/components/printing/renderer/print_render_frame_helper.cc b/components/printing/renderer/print_render_frame_helper.cc
- index 3797c58b29136c22f9545cfb64a5ce50d7f3b07a..c0107f561f444d537735d4725c6dbecbcaf45226 100644
- --- a/components/printing/renderer/print_render_frame_helper.cc
- +++ b/components/printing/renderer/print_render_frame_helper.cc
- @@ -44,6 +44,7 @@
- #include "printing/metafile_skia.h"
- #include "printing/mojom/print.mojom.h"
- #include "printing/printing_features.h"
- +#include "printing/print_settings.h"
- #include "printing/units.h"
- #include "third_party/blink/public/common/associated_interfaces/associated_interface_registry.h"
- #include "third_party/blink/public/common/css/page_orientation.h"
- @@ -1157,7 +1158,8 @@ void PrintRenderFrameHelper::ScriptedPrint(bool user_initiated) {
- web_frame->DispatchBeforePrintEvent();
- if (!weak_this)
- return;
- - Print(web_frame, blink::WebNode(), PrintRequestType::kScripted);
- + Print(web_frame, blink::WebNode(), PrintRequestType::kScripted,
- + false /* silent */, base::DictionaryValue() /* new_settings */);
- if (weak_this)
- web_frame->DispatchAfterPrintEvent();
- }
- @@ -1178,7 +1180,7 @@ void PrintRenderFrameHelper::BindPrintRenderFrameReceiver(
- receivers_.Add(this, std::move(receiver));
- }
-
- -void PrintRenderFrameHelper::PrintRequestedPages() {
- +void PrintRenderFrameHelper::PrintRequestedPages(bool silent, base::Value settings) {
- ScopedIPC scoped_ipc(weak_ptr_factory_.GetWeakPtr());
- if (ipc_nesting_level_ > 1)
- return;
- @@ -1192,7 +1194,7 @@ void PrintRenderFrameHelper::PrintRequestedPages() {
- // If we are printing a PDF extension frame, find the plugin node and print
- // that instead.
- auto plugin = delegate_->GetPdfElement(frame);
- - Print(frame, plugin, PrintRequestType::kRegular);
- + Print(frame, plugin, PrintRequestType::kRegular, silent, std::move(settings));
- if (!render_frame_gone_)
- frame->DispatchAfterPrintEvent();
- // WARNING: |this| may be gone at this point. Do not do any more work here and
- @@ -1209,7 +1211,7 @@ void PrintRenderFrameHelper::PrintForSystemDialog() {
- return;
- }
- Print(frame, print_preview_context_.source_node(),
- - PrintRequestType::kRegular);
- + PrintRequestType::kRegular, false, base::DictionaryValue());
- if (!render_frame_gone_)
- frame->DispatchAfterPrintEvent();
- // WARNING: |this| may be gone at this point. Do not do any more work here and
- @@ -1257,6 +1259,8 @@ void PrintRenderFrameHelper::PrintPreview(base::Value settings) {
- if (ipc_nesting_level_ > 1)
- return;
-
- + blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
- + print_preview_context_.InitWithFrame(frame);
- print_preview_context_.OnPrintPreview();
-
- if (print_preview_context_.IsForArc()) {
- @@ -1774,7 +1778,9 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
-
- auto self = weak_ptr_factory_.GetWeakPtr();
- Print(duplicate_node.GetDocument().GetFrame(), duplicate_node,
- - PrintRequestType::kRegular);
- + PrintRequestType::kRegular,
- + false /* silent */,
- + base::DictionaryValue() /* new_settings */);
- // Check if |this| is still valid.
- if (!self)
- return;
- @@ -1785,7 +1791,9 @@ void PrintRenderFrameHelper::PrintNode(const blink::WebNode& node) {
-
- void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
- const blink::WebNode& node,
- - PrintRequestType print_request_type) {
- + PrintRequestType print_request_type,
- + bool silent,
- + base::Value settings) {
- // If still not finished with earlier print request simply ignore.
- if (prep_frame_view_)
- return;
- @@ -1793,7 +1801,7 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
- FrameReference frame_ref(frame);
-
- int expected_page_count = 0;
- - if (!CalculateNumberOfPages(frame, node, &expected_page_count)) {
- + if (!CalculateNumberOfPages(frame, node, &expected_page_count, base::Value::AsDictionaryValue(settings))) {
- DidFinishPrinting(FAIL_PRINT_INIT);
- return; // Failed to init print page settings.
- }
- @@ -1813,8 +1821,11 @@ void PrintRenderFrameHelper::Print(blink::WebLocalFrame* frame,
-
- PrintMsg_PrintPages_Params print_settings;
- auto self = weak_ptr_factory_.GetWeakPtr();
- - GetPrintSettingsFromUser(frame_ref.GetFrame(), node, expected_page_count,
- - print_request_type, &print_settings);
- + if (silent)
- + print_settings = *print_pages_params_.get();
- + else
- + GetPrintSettingsFromUser(frame_ref.GetFrame(), node, expected_page_count,
- + print_request_type, &print_settings);
- // Check if |this| is still valid.
- if (!self)
- return;
- @@ -2049,10 +2060,23 @@ void PrintRenderFrameHelper::IPCProcessed() {
- base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
- }
-
- -bool PrintRenderFrameHelper::InitPrintSettings(bool fit_to_paper_size) {
- +bool PrintRenderFrameHelper::InitPrintSettings(
- + bool fit_to_paper_size,
- + const base::DictionaryValue& new_settings) {
- PrintMsg_PrintPages_Params settings;
- - Send(new PrintHostMsg_GetDefaultPrintSettings(routing_id(),
- - &settings.params));
- + if (new_settings.empty()) {
- + // Send the default IPC message if caller is window.print()
- + Send(new PrintHostMsg_GetDefaultPrintSettings(routing_id(),
- + &settings.params));
- + } else {
- + // Send the update IPC message if caller is webContents.print()
- + bool canceled = false;
- + Send(new PrintHostMsg_UpdatePrintSettings(
- + routing_id(), 0, new_settings, &settings, &canceled));
- + if (canceled)
- + return false;
- + }
- +
- // Check if the printer returned any settings, if the settings is empty, we
- // can safely assume there are no printer drivers configured. So we safely
- // terminate.
- @@ -2072,12 +2096,14 @@ bool PrintRenderFrameHelper::InitPrintSettings(bool fit_to_paper_size) {
- return result;
- }
-
- -bool PrintRenderFrameHelper::CalculateNumberOfPages(blink::WebLocalFrame* frame,
- - const blink::WebNode& node,
- - int* number_of_pages) {
- +bool PrintRenderFrameHelper::CalculateNumberOfPages(
- + blink::WebLocalFrame* frame,
- + const blink::WebNode& node,
- + int* number_of_pages,
- + const base::DictionaryValue& settings) {
- DCHECK(frame);
- bool fit_to_paper_size = !IsPrintingNodeOrPdfFrame(frame, node);
- - if (!InitPrintSettings(fit_to_paper_size)) {
- + if (!InitPrintSettings(fit_to_paper_size, settings)) {
- notify_browser_of_print_failure_ = false;
- Send(new PrintHostMsg_ShowInvalidPrinterSettingsError(routing_id()));
- return false;
- diff --git a/components/printing/renderer/print_render_frame_helper.h b/components/printing/renderer/print_render_frame_helper.h
- index e6d759d06c0b8f39c7f02b680d70c5eb6faf2888..be412a35088e8463b39647c9d814f8b00867f71d 100644
- --- a/components/printing/renderer/print_render_frame_helper.h
- +++ b/components/printing/renderer/print_render_frame_helper.h
- @@ -225,7 +225,7 @@ class PrintRenderFrameHelper
- mojo::PendingAssociatedReceiver<mojom::PrintRenderFrame> receiver);
-
- // printing::mojom::PrintRenderFrame:
- - void PrintRequestedPages() override;
- + void PrintRequestedPages(bool silent, base::Value settings) override;
- void PrintForSystemDialog() override;
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- void SetPrintPreviewUI(
- @@ -292,7 +292,9 @@ class PrintRenderFrameHelper
- // WARNING: |this| may be gone after this method returns.
- void Print(blink::WebLocalFrame* frame,
- const blink::WebNode& node,
- - PrintRequestType print_request_type);
- + PrintRequestType print_request_type,
- + bool silent,
- + base::Value settings);
-
- // Notification when printing is done - signal tear-down/free resources.
- void DidFinishPrinting(PrintingResult result);
- @@ -301,12 +303,14 @@ class PrintRenderFrameHelper
-
- // Initialize print page settings with default settings.
- // Used only for native printing workflow.
- - bool InitPrintSettings(bool fit_to_paper_size);
- + bool InitPrintSettings(bool fit_to_paper_size,
- + const base::DictionaryValue& settings);
-
- // Calculate number of pages in source document.
- bool CalculateNumberOfPages(blink::WebLocalFrame* frame,
- const blink::WebNode& node,
- - int* number_of_pages);
- + int* number_of_pages,
- + const base::DictionaryValue& settings);
-
- #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
- // Set options for print preset from source PDF document.
- diff --git a/printing/printing_context.cc b/printing/printing_context.cc
- index ad26397af46f024a81902949e1c7d627922ff492..e23abbac0014eac5fa0042111b920a1dec4723f8 100644
- --- a/printing/printing_context.cc
- +++ b/printing/printing_context.cc
- @@ -94,8 +94,6 @@ PrintingContext::Result PrintingContext::UsePdfSettings() {
-
- PrintingContext::Result PrintingContext::UpdatePrintSettings(
- base::Value job_settings) {
- - ResetSettings();
- -
- if (!PrintSettingsFromJobSettings(job_settings, settings_.get())) {
- NOTREACHED();
- return OnError();
- diff --git a/printing/printing_context.h b/printing/printing_context.h
- index 6a5a7c90ef5ba82837095c7bb934881b108797f7..a033c58076ff229ae45ed7c454fc60a57e5707b7 100644
- --- a/printing/printing_context.h
- +++ b/printing/printing_context.h
- @@ -131,12 +131,12 @@ class PRINTING_EXPORT PrintingContext {
-
- int job_id() const { return job_id_; }
-
- - protected:
- - explicit PrintingContext(Delegate* delegate);
- -
- // Reinitializes the settings for object reuse.
- void ResetSettings();
-
- + protected:
- + explicit PrintingContext(Delegate* delegate);
- +
- // Does bookkeeping when an error occurs.
- PrintingContext::Result OnError();
-
|