deprecate_vector_v8_local_in_v8.patch 1.1 KB

12345678910111213141516171819202122232425
  1. From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
  2. From: Shelley Vohr <[email protected]>
  3. Date: Sun, 10 Mar 2024 16:59:30 +0100
  4. Subject: Deprecate vector<v8::Local> in v8
  5. Adapts for changes in https://chromium-review.googlesource.com/c/v8/v8/+/4866222.
  6. This patch can be removed when Electron upgrades to a version of Node.js that
  7. contains the above CL.
  8. diff --git a/src/module_wrap.cc b/src/module_wrap.cc
  9. index e862b51293135995c527c32aa3c3579780d7831c..ff658ec88e5161cd66536ee6e95dba675b16eccc 100644
  10. --- a/src/module_wrap.cc
  11. +++ b/src/module_wrap.cc
  12. @@ -186,7 +186,9 @@ void ModuleWrap::New(const FunctionCallbackInfo<Value>& args) {
  13. export_names[i] = export_name_val.As<String>();
  14. }
  15. - module = Module::CreateSyntheticModule(isolate, url, export_names,
  16. +
  17. + module = Module::CreateSyntheticModule(isolate, url,
  18. + v8::MemorySpan<const Local<String>>(export_names.begin(), export_names.end()),
  19. SyntheticModuleEvaluationStepsCallback);
  20. } else {
  21. ScriptCompiler::CachedData* cached_data = nullptr;