From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 27 May 2021 17:21:07 -0700 Subject: build: do not depend on packed_resource_integrity This ensures we do not depend on a target that does not exist when building Electron, electron generates its own .pak files via electron_repack and therefore this integrity target which is generated by the chrome_paks target does not exist. This can not be upstreamed, if we ever align our .pak file generation with Chrome we can remove this patch. diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index 7e99d7493ac1f9281668eb3283f7475769245021..3b11f490c77fb667e40c30e7d61e484df1e9972f 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -202,11 +202,16 @@ if (!is_android && !is_mac) { "common/crash_keys.h", ] + if (!is_electron_build) { + deps = [ + ":packed_resources_integrity", + ] + } + deps += [ ":chrome_dll", ":chrome_exe_version", ":copy_first_run", - ":packed_resources_integrity", ":visual_elements_resources", "//base", "//build:branding_buildflags", diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn index d2207552c449f0219c6b2da984491144d14817b5..5b4bca66693337249d82545b58e6e0f1024a013d 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn @@ -4678,7 +4678,7 @@ static_library("browser") { # On Windows, the hashes are embedded in //chrome:chrome_initial rather # than here in :chrome_dll. - if (!is_win) { + if (!is_win && !is_electron_build) { deps += [ "//chrome:packed_resources_integrity" ] sources += [ "certificate_viewer_stub.cc" ] } diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn index 840813730d52d1cf930cfbb3e322dc8f328836dc..9eee8efe4a43cacc70851f3427f471f0b59024ff 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn @@ -6755,7 +6755,6 @@ test("unit_tests") { deps += [ "//chrome:other_version", - "//chrome:packed_resources_integrity", "//chrome//services/util_win:unit_tests", "//chrome/app:chrome_dll_resources", "//chrome/app:win_unit_tests", @@ -6781,6 +6780,10 @@ test("unit_tests") { "//ui/resources", ] + if (!is_electron_build) { + deps += [ "//chrome:packed_resources_integrity" ] + } + ldflags = [ "/DELAYLOAD:api-ms-win-core-winrt-error-l1-1-0.dll", "/DELAYLOAD:api-ms-win-core-winrt-l1-1-0.dll", @@ -7740,7 +7743,6 @@ test("unit_tests") { } deps += [ - "//chrome:packed_resources_integrity_hash", "//chrome/browser/apps:icon_standardizer", "//chrome/browser/apps/app_service", "//chrome/browser/apps/app_service:test_support", @@ -7826,6 +7828,10 @@ test("unit_tests") { "//ui/webui/resources/js/browser_command:mojo_bindings", ] + if (!is_electron_build) { + deps += [ "//chrome:packed_resources_integrity_hash" ] + } + data += [ "//ash/components/arc/test/data/icons/" ] if (include_js2gtest_tests) {