From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Fri, 3 Sep 2021 18:28:51 -0700 Subject: fix: expose DecrementCapturerCount in web_contents_impl This was made private in https://chromium-review.googlesource.com/c/chromium/src/+/2807829 but we invoke it in order to expose contents.decrementCapturerCount([stayHidden, stayAwake]) to users. We should try to upstream this. diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h index 55224f960151b0cae23b2a49d755eace630e9e3a..86ab5a5e5e3e881fdaf3528640f097493123da74 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h @@ -1827,7 +1827,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, // IncrementCapturerCount() is destructed. void DecrementCapturerCount(bool stay_hidden, bool stay_awake, - bool is_activity = true); + bool is_activity = true) override; // Calculates the PageVisibilityState for |visibility|, taking the capturing // state into account. diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h index d159f44dc855fee799f7b97b59a2a4e64631e7b4..b583fb7ff191d5dfce4b8fee5f06e074b3a6ea4f 100644 --- a/content/public/browser/web_contents.h +++ b/content/public/browser/web_contents.h @@ -673,6 +673,10 @@ class WebContents : public PageNavigator, bool stay_awake, bool is_activity = true) = 0; + virtual void DecrementCapturerCount(bool stay_hidden, + bool stay_awake, + bool is_activity = true) = 0; + // Getter for the capture handle, which allows a captured application to // opt-in to exposing information to its capturer(s). virtual const blink::mojom::CaptureHandleConfig& GetCaptureHandleConfig() = 0;