From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 5 Oct 2020 13:43:59 -0700 Subject: chore: expose v8 initialization isolate callbacks This commit is necessary in order to ensure consistent behavior from v8 Isolate callbacks in contexts which Node.js does not control. If we're running with contextIsolation enabled, we should be falling back to Blink's logic. This will be upstreamed in some form. diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc index 5040ec838c64ffa8aa58ba43f51df649443b2f81..7a7a87d00fa392b7bd07267d9059664d5d472252 100644 --- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc +++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc @@ -446,8 +446,9 @@ CodeGenerationCheckCallbackInMainThread(v8::Local context, return {true, std::move(stringified_source)}; } -bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread(v8::Local context, - v8::Local source) { +bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread( + v8::Local context, + v8::Local source) { if (ExecutionContext* execution_context = ToExecutionContext(context)) { if (ContentSecurityPolicy* policy = execution_context->GetContentSecurityPolicy()) { diff --git a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h index 932c6aad3df51dd6790e55bf708703767843dc5e..6865fd33e62f766c5a162ded8627c332bf2ed173 100644 --- a/third_party/blink/renderer/bindings/core/v8/v8_initializer.h +++ b/third_party/blink/renderer/bindings/core/v8/v8_initializer.h @@ -69,8 +69,8 @@ class CORE_EXPORT V8Initializer { static void MessageHandlerInWorker(v8::Local, v8::Local); static bool WasmCodeGenerationCheckCallbackInMainThread( - v8::Local context, - v8::Local source); + v8::Local context, + v8::Local source); }; } // namespace blink