From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 27 May 2021 17:21:07 -0700 Subject: build: do not depend on packed_resource_integrity This ensures we do not depend on a target that does not exist when building Electron, electron generates its own .pak files via electron_repack and therefore this integrity target which is generated by the chrome_paks target does not exist. This can not be upstreamed, if we ever align our .pak file generation with Chrome we can remove this patch. diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn index a6e0a53d4ebbd585114bc0cda2e2d1caaab4a015..95a7e70eee0303471702b81c68f46a0fea2b6f0e 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -171,11 +171,16 @@ if (!is_android && !is_mac) { "common/crash_keys.h", ] + if (!is_electron_build) { + deps = [ + ":packed_resources_integrity", + ] + } + deps += [ ":chrome_dll", ":chrome_exe_version", ":copy_first_run", - ":packed_resources_integrity", ":visual_elements_resources", "//base", "//build:branding_buildflags", diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn index fca255a2cd49f1f5d2bcb4418b04355c5befba38..2a0f3edc10a7ba48ee5a0efac0a6053f62b184e0 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn @@ -4508,7 +4508,7 @@ static_library("browser") { # On Windows, the hashes are embedded in //chrome:chrome_initial rather # than here in :chrome_dll. - if (!is_win) { + if (!is_win && !is_electron_build) { deps += [ "//chrome:packed_resources_integrity" ] sources += [ "certificate_viewer_stub.cc" ] } diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn index 3a3318c9586c88af0333d1b7586cbb426c205e7d..183d0c8ceb42a23424c3aa6d21c72e0a197ae638 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn @@ -5904,7 +5904,6 @@ test("unit_tests") { deps += [ "//chrome:other_version", - "//chrome:packed_resources_integrity", "//chrome//services/util_win:unit_tests", "//chrome/app:chrome_dll_resources", "//chrome/browser:chrome_process_finder", @@ -5927,6 +5926,10 @@ test("unit_tests") { "//ui/resources", ] + if (!is_electron_build) { + deps += [ "//chrome:packed_resources_integrity" ] + } + ldflags = [ "/DELAYLOAD:api-ms-win-core-winrt-error-l1-1-0.dll", "/DELAYLOAD:api-ms-win-core-winrt-l1-1-0.dll", @@ -6616,7 +6619,6 @@ test("unit_tests") { } deps += [ - "//chrome:packed_resources_integrity_hash", "//chrome/browser:cart_db_content_proto", "//chrome/browser:coupon_db_content_proto", "//chrome/browser/media/router:test_support", @@ -6662,6 +6664,11 @@ test("unit_tests") { "//ui/native_theme:test_support", "//ui/webui/resources/js/browser_command:mojo_bindings", ] + + if (!is_electron_build) { + deps += [ "//chrome:packed_resources_integrity_hash" ] + } + if (is_chromeos_ash) { deps += [ "//ash/assistant/model",