Browse Source

fix: add missing index arg in `navigationHistory.canGoToOffset` (#45008)

fix: add missing arg

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: alice <[email protected]>
trop[bot] 4 months ago
parent
commit
fd117af7ce
2 changed files with 3 additions and 3 deletions
  1. 2 2
      lib/browser/api/web-contents.ts
  2. 1 1
      typings/internal-electron.d.ts

+ 2 - 2
lib/browser/api/web-contents.ts

@@ -514,9 +514,9 @@ WebContents.prototype.canGoForward = function () {
 };
 
 const canGoToOffsetDeprecated = deprecate.warnOnce('webContents.canGoToOffset', 'webContents.navigationHistory.canGoToOffset');
-WebContents.prototype.canGoToOffset = function () {
+WebContents.prototype.canGoToOffset = function (index: number) {
   canGoToOffsetDeprecated();
-  return this._canGoToOffset();
+  return this._canGoToOffset(index);
 };
 
 const clearHistoryDeprecated = deprecate.warnOnce('webContents.clearHistory', 'webContents.navigationHistory.clear');

+ 1 - 1
typings/internal-electron.d.ts

@@ -93,7 +93,7 @@ declare namespace Electron {
     _historyLength(): number;
     _canGoBack(): boolean;
     _canGoForward(): boolean;
-    _canGoToOffset(): boolean;
+    _canGoToOffset(index: number): boolean;
     _goBack(): void;
     _goForward(): void;
     _goToOffset(index: number): void;