Browse Source

fix: prevent crash in ListValue v8 converter when conversion fails (#22753)

Samuel Attard 5 years ago
parent
commit
f3fd40c221
1 changed files with 1 additions and 1 deletions
  1. 1 1
      shell/common/gin_converters/value_converter.cc

+ 1 - 1
shell/common/gin_converters/value_converter.cc

@@ -59,7 +59,7 @@ bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
   electron::V8ValueConverter converter;
   std::unique_ptr<base::Value> value(
       converter.FromV8Value(val, isolate->GetCurrentContext()));
-  if (value->is_list()) {
+  if (value && value->is_list()) {
     out->Swap(static_cast<base::ListValue*>(value.get()));
     return true;
   } else {