Browse Source

Fix build/include_what_you_use linter violations in brightray

Kevin Sawicki 8 years ago
parent
commit
f193b2b2a6
28 changed files with 60 additions and 4 deletions
  1. 1 1
      brightray/CPPLINT.cfg
  2. 3 0
      brightray/browser/browser_client.h
  3. 1 0
      brightray/browser/browser_context.h
  4. 2 0
      brightray/browser/devtools_file_system_indexer.cc
  5. 2 0
      brightray/browser/devtools_manager_delegate.h
  6. 2 0
      brightray/browser/inspectable_web_contents.h
  7. 4 0
      brightray/browser/inspectable_web_contents_impl.h
  8. 2 0
      brightray/browser/inspectable_web_contents_view_delegate.h
  9. 2 0
      brightray/browser/linux/libnotify_notification.h
  10. 2 0
      brightray/browser/mac/cocoa_notification.h
  11. 2 0
      brightray/browser/media/media_capture_devices_dispatcher.h
  12. 2 1
      brightray/browser/net/devtools_network_protocol_handler.cc
  13. 2 0
      brightray/browser/net/devtools_network_transaction.cc
  14. 3 0
      brightray/browser/net/devtools_network_transaction_factory.cc
  15. 2 0
      brightray/browser/notification.h
  16. 2 0
      brightray/browser/permission_manager.h
  17. 3 0
      brightray/browser/platform_notification_service.h
  18. 3 0
      brightray/browser/url_request_context_getter.h
  19. 2 0
      brightray/browser/views/views_delegate.h
  20. 3 0
      brightray/browser/win/notification_presenter_win.cc
  21. 3 0
      brightray/browser/win/notification_presenter_win7.cc
  22. 4 0
      brightray/browser/win/win32_notification.cc
  23. 1 0
      brightray/browser/win/windows_toast_notification.h
  24. 1 0
      brightray/browser/zoom_level_delegate.cc
  25. 2 0
      brightray/browser/zoom_level_delegate.h
  26. 1 2
      brightray/common/content_client.cc
  27. 2 0
      brightray/common/content_client.h
  28. 1 0
      brightray/common/main_delegate.h

+ 1 - 1
brightray/CPPLINT.cfg

@@ -1 +1 @@
-filter=-build/include_what_you_use,-legal/copyright,-runtime/references
+filter=-legal/copyright,-runtime/references

+ 3 - 0
brightray/browser/browser_client.h

@@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_BROWSER_CLIENT_H_
 #define BRIGHTRAY_BROWSER_BROWSER_CLIENT_H_
 
+#include <string>
+#include <vector>
+
 #include "browser/net_log.h"
 #include "content/public/browser/content_browser_client.h"
 

+ 1 - 0
brightray/browser/browser_context.h

@@ -6,6 +6,7 @@
 #define BRIGHTRAY_BROWSER_BROWSER_CONTEXT_H_
 
 #include <map>
+#include <string>
 
 #include "browser/net/devtools_network_controller_handle.h"
 #include "browser/permission_manager.h"

+ 2 - 0
brightray/browser/devtools_file_system_indexer.cc

@@ -6,7 +6,9 @@
 
 #include <stddef.h>
 
+#include <algorithm>
 #include <iterator>
+#include <set>
 
 #include "base/bind.h"
 #include "base/files/file_enumerator.h"

+ 2 - 0
brightray/browser/devtools_manager_delegate.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
 
+#include <string>
+
 #include "base/macros.h"
 #include "base/compiler_specific.h"
 #include "content/public/browser/devtools_manager_delegate.h"

+ 2 - 0
brightray/browser/inspectable_web_contents.h

@@ -1,6 +1,8 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_H_
 
+#include <string>
+
 #include "content/public/browser/web_contents.h"
 
 namespace base {

+ 4 - 0
brightray/browser/inspectable_web_contents_impl.h

@@ -6,6 +6,10 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_IMPL_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_IMPL_H_
 
+#include <map>
+#include <string>
+#include <vector>
+
 #include "browser/inspectable_web_contents.h"
 
 #include "browser/devtools_contents_resizing_strategy.h"

+ 2 - 0
brightray/browser/inspectable_web_contents_view_delegate.h

@@ -1,6 +1,8 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_VIEW_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_VIEW_DELEGATE_H_
 
+#include <string>
+
 #include "ui/gfx/image/image_skia.h"
 
 namespace brightray {

+ 2 - 0
brightray/browser/linux/libnotify_notification.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_NOTIFICATION_H_
 #define BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_NOTIFICATION_H_
 
+#include <string>
+
 #include "browser/linux/libnotify_loader.h"
 #include "browser/notification.h"
 #include "ui/base/glib/glib_signal.h"

+ 2 - 0
brightray/browser/mac/cocoa_notification.h

@@ -7,6 +7,8 @@
 
 #import <Foundation/Foundation.h>
 
+#include <string>
+
 #include "base/mac/scoped_nsobject.h"
 #include "browser/notification.h"
 

+ 2 - 0
brightray/browser/media/media_capture_devices_dispatcher.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_MEDIA_MEDIA_CAPTURE_DEVICES_DISPATCHER_H_
 #define BRIGHTRAY_BROWSER_MEDIA_MEDIA_CAPTURE_DEVICES_DISPATCHER_H_
 
+#include <string>
+
 #include "base/memory/singleton.h"
 #include "content/public/browser/media_observer.h"
 #include "content/public/common/media_stream_request.h"

+ 2 - 1
brightray/browser/net/devtools_network_protocol_handler.cc

@@ -4,6 +4,8 @@
 
 #include "browser/net/devtools_network_protocol_handler.h"
 
+#include <string>
+
 #include "browser/browser_context.h"
 #include "browser/net/devtools_network_conditions.h"
 #include "browser/net/devtools_network_controller.h"
@@ -12,7 +14,6 @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/devtools_agent_host.h"
 
-
 namespace brightray {
 
 namespace {

+ 2 - 0
brightray/browser/net/devtools_network_transaction.cc

@@ -4,6 +4,8 @@
 
 #include "browser/net/devtools_network_transaction.h"
 
+#include <string>
+
 #include "browser/net/devtools_network_controller.h"
 #include "browser/net/devtools_network_upload_data_stream.h"
 #include "net/base/load_timing_info.h"

+ 3 - 0
brightray/browser/net/devtools_network_transaction_factory.cc

@@ -4,6 +4,9 @@
 
 #include "browser/net/devtools_network_transaction_factory.h"
 
+#include <set>
+#include <string>
+
 #include "browser/net/devtools_network_controller.h"
 #include "browser/net/devtools_network_transaction.h"
 

+ 2 - 0
brightray/browser/notification.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_NOTIFICATION_H_
 #define BRIGHTRAY_BROWSER_NOTIFICATION_H_
 
+#include <string>
+
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"
 

+ 2 - 0
brightray/browser/permission_manager.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_PERMISSION_MANAGER_H_
 #define BRIGHTRAY_BROWSER_PERMISSION_MANAGER_H_
 
+#include <vector>
+
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "content/public/browser/permission_manager.h"

+ 3 - 0
brightray/browser/platform_notification_service.h

@@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_PLATFORM_NOTIFICATION_SERVICE_H_
 #define BRIGHTRAY_BROWSER_PLATFORM_NOTIFICATION_SERVICE_H_
 
+#include <set>
+#include <string>
+
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/platform_notification_service.h"
 

+ 3 - 0
brightray/browser/url_request_context_getter.h

@@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_URL_REQUEST_CONTEXT_GETTER_H_
 #define BRIGHTRAY_BROWSER_URL_REQUEST_CONTEXT_GETTER_H_
 
+#include <string>
+#include <vector>
+
 #include "base/files/file_path.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"

+ 2 - 0
brightray/browser/views/views_delegate.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_VIEWS_VIEWS_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_VIEWS_VIEWS_DELEGATE_H_
 
+#include <string>
+
 #include "base/compiler_specific.h"
 #include "ui/views/views_delegate.h"
 

+ 3 - 0
brightray/browser/win/notification_presenter_win.cc

@@ -6,6 +6,9 @@
 
 #include "browser/win/notification_presenter_win.h"
 
+#include <string>
+#include <vector>
+
 #include "base/files/file_util.h"
 #include "base/md5.h"
 #include "base/strings/utf_string_conversions.h"

+ 3 - 0
brightray/browser/win/notification_presenter_win7.cc

@@ -1,4 +1,7 @@
 #include "browser/win/notification_presenter_win7.h"
+
+#include <string>
+
 #include "browser/win/win32_notification.h"
 
 namespace brightray {

+ 4 - 0
brightray/browser/win/win32_notification.cc

@@ -1,6 +1,10 @@
 #define WIN32_LEAN_AND_MEAN
+
 #include "browser/win/win32_notification.h"
+
 #include <windows.h>
+#include <string>
+
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace brightray {

+ 1 - 0
brightray/browser/win/windows_toast_notification.h

@@ -12,6 +12,7 @@
 #include <windows.h>
 #include <windows.ui.notifications.h>
 #include <wrl/implements.h>
+#include <string>
 
 #include "browser/notification.h"
 

+ 1 - 0
brightray/browser/zoom_level_delegate.cc

@@ -5,6 +5,7 @@
 #include "browser/zoom_level_delegate.h"
 
 #include <functional>
+#include <vector>
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"

+ 2 - 0
brightray/browser/zoom_level_delegate.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_ZOOM_LEVEL_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_ZOOM_LEVEL_DELEGATE_H_
 
+#include <string>
+
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "components/prefs/pref_service.h"

+ 1 - 2
brightray/common/content_client.cc

@@ -4,10 +4,9 @@
 
 #include "common/content_client.h"
 
-#include "common/application_info.h"
-
 #include "base/strings/stringprintf.h"
 #include "base/strings/string_util.h"
+#include "common/application_info.h"
 #include "content/public/common/user_agent.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"

+ 2 - 0
brightray/common/content_client.h

@@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_COMMON_CONTENT_CLIENT_H_
 #define BRIGHTRAY_COMMON_CONTENT_CLIENT_H_
 
+#include <string>
+
 #include "base/compiler_specific.h"
 #include "content/public/common/content_client.h"
 

+ 1 - 0
brightray/common/main_delegate.h

@@ -6,6 +6,7 @@
 #define BRIGHTRAY_COMMON_MAIN_DELEGATE_H_
 
 #include <memory>
+#include <string>
 
 #include "base/macros.h"
 #include "content/public/app/content_main_delegate.h"