Browse Source

chore: remove unused internal env.unSetVar() (#43148)

chore: remove unused unSetVar JS binding

Added in Oct 2020 (b33f2260, #25623) but never used
Charles Kerr 8 months ago
parent
commit
e7ca92a574
2 changed files with 0 additions and 6 deletions
  1. 0 5
      shell/common/api/electron_api_environment.cc
  2. 0 1
      typings/internal-ambient.d.ts

+ 0 - 5
shell/common/api/electron_api_environment.cc

@@ -25,10 +25,6 @@ bool SetVar(const std::string& name, const std::string& value) {
   return base::Environment::Create()->SetVar(name, value);
 }
 
-bool UnSetVar(const std::string& name) {
-  return base::Environment::Create()->UnSetVar(name);
-}
-
 void Initialize(v8::Local<v8::Object> exports,
                 v8::Local<v8::Value> unused,
                 v8::Local<v8::Context> context,
@@ -37,7 +33,6 @@ void Initialize(v8::Local<v8::Object> exports,
   dict.SetMethod("getVar", &GetVar);
   dict.SetMethod("hasVar", &HasVar);
   dict.SetMethod("setVar", &SetVar);
-  dict.SetMethod("unSetVar", &UnSetVar);
 }
 
 }  // namespace

+ 0 - 1
typings/internal-ambient.d.ts

@@ -52,7 +52,6 @@ declare namespace NodeJS {
     getVar(name: string): string | null;
     hasVar(name: string): boolean;
     setVar(name: string, value: string): boolean;
-    unSetVar(name: string): boolean;
   }
 
   type AsarFileInfo = {