Browse Source

disable robotjs-based tests

See #18409
Jeremy Apthorp 6 years ago
parent
commit
e56adafc1f
2 changed files with 6 additions and 2 deletions
  1. 3 1
      spec/api-menu-spec.js
  2. 3 1
      spec/api-web-contents-spec.js

+ 3 - 1
spec/api-menu-spec.js

@@ -835,7 +835,9 @@ describe('Menu module', () => {
     })
   })
 
-  describe('menu accelerators', () => {
+  // FIXME(nornagon): this is disabled due to an issue with nan in current v8.
+  // See https://github.com/electron/electron/issues/18409
+  describe.skip('menu accelerators', () => {
     let testFn = it
     try {
       // We have other tests that check if native modules work, if we fail to require

+ 3 - 1
spec/api-web-contents-spec.js

@@ -382,7 +382,9 @@ describe('webContents module', () => {
     })
   })
 
-  describe('devtools window', () => {
+  // FIXME(nornagon): this is disabled due to an issue with nan in current v8.
+  // See https://github.com/electron/electron/issues/18409
+  describe.skip('devtools window', () => {
     let testFn = it
     if (process.platform === 'darwin' && isCi) {
       testFn = it.skip