Browse Source

ci: fix WOA failing tests (10-x-y) (#25107)

* tests: fix early-in-memory-session-create crash test on WOA

ci: cleanup user app data directories on WOA
(cherry picked from commit 43106d28d8425fd3056d329957beba1503d16f22)

* Renable crash tests on WOA
John Kleinschmidt 4 years ago
parent
commit
e492b88f9f

+ 5 - 1
azure-pipelines-woa.yml

@@ -87,7 +87,11 @@ steps:
 
 - powershell: |
     Get-Process | Where Name –Like "electron*" | Stop-Process
-    Get-Process | Where Name –Like "MicrosoftEdge*" | Stop-Process
     Get-Process | Where Name –Like "msedge*" | Stop-Process
   displayName: 'Kill processes left running from last test run'
   condition: always()
+
+- powershell: |
+    Remove-Item -path $env:APPDATA/Electron* -Recurse
+  displayName: 'Delete user app data directories'
+  condition: always()

+ 1 - 3
spec-main/crash-spec.ts

@@ -2,7 +2,6 @@ import { expect } from 'chai';
 import * as cp from 'child_process';
 import * as fs from 'fs';
 import * as path from 'path';
-import { ifdescribe } from './spec-helpers';
 
 const fixturePath = path.resolve(__dirname, 'fixtures', 'crash-cases');
 
@@ -31,8 +30,7 @@ const runFixtureAndEnsureCleanExit = (args: string[]) => {
   });
 };
 
-// TODO re-enable this test for WOA
-ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('crash cases', () => {
+describe('crash cases', () => {
   afterEach(() => {
     for (const child of children) {
       child.kill();

+ 3 - 1
spec-main/fixtures/crash-cases/early-in-memory-session-create/index.js

@@ -2,5 +2,7 @@ const { app, session } = require('electron');
 
 app.on('ready', () => {
   session.fromPartition('in-memory');
-  process.exit(0);
+  setImmediate(() => {
+    process.exit(0);
+  });
 });