Browse Source

refactor: use `= default` to define trivial destructors (#46190)

refactor: use '= default' to define trivial destructors

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <[email protected]>
trop[bot] 4 weeks ago
parent
commit
dea35330c0

+ 1 - 1
shell/browser/api/electron_api_view.cc

@@ -155,7 +155,7 @@ class JSLayoutManager : public views::LayoutManagerBase {
  public:
   explicit JSLayoutManager(LayoutCallback layout_callback)
       : layout_callback_(std::move(layout_callback)) {}
-  ~JSLayoutManager() override {}
+  ~JSLayoutManager() override = default;
 
   // views::LayoutManagerBase
   views::ProposedLayout CalculateProposedLayout(

+ 0 - 6
shell/browser/extensions/api/extension_action/extension_action_api.cc

@@ -29,8 +29,6 @@ void ExtensionActionAPI::Observer::OnExtensionActionUpdated(
 
 void ExtensionActionAPI::Observer::OnExtensionActionAPIShuttingDown() {}
 
-ExtensionActionAPI::Observer::~Observer() {}
-
 //
 // ExtensionActionAPI
 //
@@ -38,8 +36,6 @@ ExtensionActionAPI::Observer::~Observer() {}
 ExtensionActionAPI::ExtensionActionAPI(content::BrowserContext* context)
     : browser_context_(context), extension_prefs_(nullptr) {}
 
-ExtensionActionAPI::~ExtensionActionAPI() {}
-
 // static
 BrowserContextKeyedAPIFactory<ExtensionActionAPI>*
 ExtensionActionAPI::GetFactoryInstance() {
@@ -65,8 +61,6 @@ void ExtensionActionAPI::Shutdown() {}
 
 ExtensionActionFunction::ExtensionActionFunction() {}
 
-ExtensionActionFunction::~ExtensionActionFunction() {}
-
 ExtensionFunction::ResponseAction ExtensionActionFunction::Run() {
   return RunExtensionAction();
 }

+ 3 - 3
shell/browser/extensions/api/extension_action/extension_action_api.h

@@ -33,7 +33,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
     virtual void OnExtensionActionAPIShuttingDown();
 
    protected:
-    virtual ~Observer();
+    virtual ~Observer() = default;
   };
 
   explicit ExtensionActionAPI(content::BrowserContext* context);
@@ -41,7 +41,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
   ExtensionActionAPI(const ExtensionActionAPI&) = delete;
   ExtensionActionAPI& operator=(const ExtensionActionAPI&) = delete;
 
-  ~ExtensionActionAPI() override;
+  ~ExtensionActionAPI() override = default;
 
   // Convenience method to get the instance for a profile.
   static ExtensionActionAPI* Get(content::BrowserContext* context);
@@ -86,7 +86,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
 class ExtensionActionFunction : public ExtensionFunction {
  protected:
   ExtensionActionFunction();
-  ~ExtensionActionFunction() override;
+  ~ExtensionActionFunction() override = default;
 
   // ExtensionFunction
   ResponseAction Run() override;

+ 1 - 1
shell/browser/net/web_request_api_interface.h

@@ -20,7 +20,7 @@ namespace electron {
 // Defines the interface for WebRequest API, implemented by api::WebRequestNS.
 class WebRequestAPI {
  public:
-  virtual ~WebRequestAPI() {}
+  virtual ~WebRequestAPI() = default;
 
   using BeforeSendHeadersCallback =
       base::OnceCallback<void(const std::set<std::string>& removed_headers,