Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

fix: missing HandleScope in OnDownloadPathGenerated (#23005)

Shelley Vohr 5 years ago
parent
29f773e008
commit
de893360f7
1 changed files with 1 additions and 0 deletions
Split View Show Diff Stats
  1. 1 0
      shell/browser/electron_download_manager_delegate.cc

+ 1 - 0
shell/browser/electron_download_manager_delegate.cc
View File 

@@ -117,6 +117,7 @@ void ElectronDownloadManagerDelegate::OnDownloadPathGenerated(
 
     settings.force_detached = offscreen;
 
 
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
 
+    v8::HandleScope scope(isolate);
 
     gin_helper::Promise<gin_helper::Dictionary> dialog_promise(isolate);
 
     auto dialog_callback = base::BindOnce(
 
         &ElectronDownloadManagerDelegate::OnDownloadSaveDialogDone,